Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6474: adding support to migrate to jakarta 10 #164

Conversation

breakponchito
Copy link
Contributor

@breakponchito breakponchito commented Dec 8, 2022

Description:
Changes to add support to migrate application to Jakarta 10

Tested:
On local environment with VSCode IDE

Environment:
Windows 11, nodejs V16.18.0, npm 8.19.2

Result of tests:

  • migrate file to jakarta 10 with different folder
migrate_file_different_folder.mp4
  • migrate file to jakarta 10 on the same folder (override)
migrate_file_same_folder_override.mp4
  • migrate folder to jakarta 10 to different location
migrate_folder_to_different_folder.mp4
  • migrate folder to jakarta 10 on the same folder (override)
migrate_folder_same_folder_override.mp4

@breakponchito
Copy link
Contributor Author

changes added to resolve comments from demo with @jGauravGupta

Copy link
Contributor

@jGauravGupta jGauravGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- On pressing no button, no action placed.
2- Also my suggestion, Change the text "By hand" => "manually" and "Jakarta 10" => "Jakarta EE 10"

@jGauravGupta jGauravGupta merged commit ebe3710 into payara:master Dec 23, 2022
@jGauravGupta jGauravGupta added this to the 1.2.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants