Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroProfile Rest Client paths are reported as application paths /CUSTCOM-131 #4180

Closed
edthorne opened this issue Aug 26, 2019 · 4 comments
Closed
Assignees
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect

Comments

@edthorne
Copy link
Contributor

MicroProfile Rest Client paths are reported as application paths

When deploying an application that contains MicroProfile Rest Client interfaces, several warnings are logged and the paths appear in the list of REST endpoints on startup. The endpoint is also documented in the application.wadl.

Expected Outcome

MicroProfile Rest Client interfaces should not appear in the application's endpoints. Prior to version 5.192, these endpoints did not appear.

Current Outcome

Using this example, you can see the following in the client output:

[2019-08-26T13:56:45.366-0500] [] [WARNING] [] [org.glassfish.jersey.ext.cdi1x.internal.CdiComponentProvider] [tid: _ThreadID=1 _ThreadName=main] [timeMillis: 1566845805366] [levelValue: 900] Component of class interface com.example.client.HelloService cannot be instantiated and will be ignored.

[2019-08-26T13:56:45.367-0500] [] [WARNING] [] [org.glassfish.jersey.server.ResourceModelConfigurator] [tid: _ThreadID=1 _ThreadName=main] [timeMillis: 1566845805367] [levelValue: 900] Component of class interface com.example.client.HelloService cannot be instantiated and will be ignored.

...

[2019-08-26T13:01:25.079-0500] [] [INFO] [] [PayaraMicro] [tid: _ThreadID=1 _ThreadName=main] [timeMillis: 1566842485079] [levelValue: 800] [[

Payara Micro URLs:
http://<host>:8086/client

'client' REST Endpoints:
GET	/client/api/api/hello/{name}
GET	/client/api/application.wadl
GET	/client/api/client
GET	/client/api/client/programmatic
GET	/client/api/client/retry
GET	/client/api/client/service

]]

The path GET /client/api/api/hello/{name} is not part of the deployed JAX-RS resources.

Steps to reproduce

Deploy an application that contains a MicroProfile Rest Client on version 5.192 or higher.

Samples

https://github.com/edthorne/ftrestclient

Environment

  • Payara Version: 5.192
  • Edition: Micro
  • JDK Version: OpenJDK 1.8.0_201
  • Operating System: Linux
@edthorne
Copy link
Contributor Author

I don't know if it's related to Payara-Examples #104. That issue also started in the 5.191 to 5.192 transition. In that case, I believe the Rest Client interface HelloService is being discovered and validation is being applied where it wasn't previously.

Because the interface is being "deployed" and therefore validated, the duplicate resource paths for the sync and async invocations violate the JAX-RS uniqueness constraints for path and produces/consumes. That pair of signatures don't appear to violate the MicroProfile Rest Client constraints and worked previously on version 5.191.

@rdebusscher rdebusscher self-assigned this Aug 30, 2019
@rdebusscher rdebusscher added 0:Triaged Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect labels Aug 30, 2019
@rdebusscher
Copy link

Hi Ed,

I have created the internal issue PAYARA-4106 to fix this.

Thanks for the report and the link to the reproducer.

@fturizo fturizo removed the 0:Triaged label Nov 21, 2019
@rdebusscher
Copy link

Tracked as CUSTCOM-131

@OndroMih OndroMih changed the title MicroProfile Rest Client paths are reported as application paths MicroProfile Rest Client paths are reported as application paths /CUSTCOM-131 Feb 4, 2020
@AlanRoth
Copy link

Hi, due to how long ago this issue was raised we have decided to close the issue immediately, and not consider the implementation of the fix/improvement that was requested. Please understand that this decision was taken into consideration with the resources that we have available at the moment. In case of having reported a bug, if the issue is still pressing to you, feel free to verify if it’s applicable in the current release of Payara Community edition, and proceed to raise a new issue with details of the test reproducer. Many thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect
Projects
None yet
Development

No branches or pull requests

4 participants