From 0e71f443b7decff9eaf27cc9695c244f447fb12e Mon Sep 17 00:00:00 2001
From: Andrew Pielage <pandrex247@hotmail.com>
Date: Wed, 13 Sep 2023 16:35:51 +0100
Subject: [PATCH 1/2] FISH-7809 Remove deploy-internals profile and fix
 deployment of Core

With the introduction of Core, the deploy-internals profile becomes redundant.

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
---
 appserver/distributions/pom.xml               |  9 -----
 appserver/extras/embedded/all/pom.xml         |  6 ---
 appserver/extras/embedded/pom.xml             |  8 ----
 appserver/extras/embedded/web/pom.xml         |  6 ---
 .../payara-micro-distribution/pom.xml         |  6 ---
 core/core-parent/pom.xml                      | 22 -----------
 core/pom.xml                                  | 22 ++++++++++-
 pom.xml                                       | 37 +++++--------------
 8 files changed, 30 insertions(+), 86 deletions(-)

diff --git a/appserver/distributions/pom.xml b/appserver/distributions/pom.xml
index 65b58ec1bc7..81d828b0949 100644
--- a/appserver/distributions/pom.xml
+++ b/appserver/distributions/pom.xml
@@ -189,15 +189,6 @@
     </build>
 
     <profiles>
-
-        <!-- Don't deploy any distributions if only the internals are being deployed -->
-        <profile>
-            <id>deploy-internals</id>
-            <properties>
-                <deploy.skip>true</deploy.skip>
-            </properties>
-        </profile>
-
         <!-- Default build profile -->
         <profile>
             <id>DefaultBuild</id>
diff --git a/appserver/extras/embedded/all/pom.xml b/appserver/extras/embedded/all/pom.xml
index b6db59898cd..6bd6fbe3b8b 100644
--- a/appserver/extras/embedded/all/pom.xml
+++ b/appserver/extras/embedded/all/pom.xml
@@ -481,11 +481,5 @@
                 </plugins>
             </build>
         </profile>
-        <profile>
-            <id>deploy-internals</id>
-            <properties>
-                <deploy.skip>true</deploy.skip>
-            </properties>
-        </profile>
     </profiles>
 </project>
diff --git a/appserver/extras/embedded/pom.xml b/appserver/extras/embedded/pom.xml
index ca9ef9e7b0d..a51af65cad9 100644
--- a/appserver/extras/embedded/pom.xml
+++ b/appserver/extras/embedded/pom.xml
@@ -60,12 +60,4 @@
         <module>tests</module>
     </modules>
 
-    <profiles>
-        <profile>
-            <id>deploy-internals</id>
-            <properties>
-                <deploy.skip>true</deploy.skip>
-            </properties>
-        </profile>
-    </profiles>
 </project>
diff --git a/appserver/extras/embedded/web/pom.xml b/appserver/extras/embedded/web/pom.xml
index 3552c9ee16f..c73e49c0733 100644
--- a/appserver/extras/embedded/web/pom.xml
+++ b/appserver/extras/embedded/web/pom.xml
@@ -419,11 +419,5 @@
                 </plugins>
             </build>
         </profile>
-        <profile>
-            <id>deploy-internals</id>
-            <properties>
-                <deploy.skip>true</deploy.skip>
-            </properties>
-        </profile>
     </profiles>
 </project>
diff --git a/appserver/extras/payara-micro/payara-micro-distribution/pom.xml b/appserver/extras/payara-micro/payara-micro-distribution/pom.xml
index 35f10cebdec..7876f654ffa 100644
--- a/appserver/extras/payara-micro/payara-micro-distribution/pom.xml
+++ b/appserver/extras/payara-micro/payara-micro-distribution/pom.xml
@@ -528,11 +528,5 @@
                 <product.name>Payara Micro Enterprise</product.name>
             </properties>
         </profile>
-        <profile>
-            <id>deploy-internals</id>
-            <properties>
-                <deploy.skip>true</deploy.skip>
-            </properties>
-        </profile>
     </profiles>
 </project>
diff --git a/core/core-parent/pom.xml b/core/core-parent/pom.xml
index 1e9fa1abb86..3f52e47c751 100644
--- a/core/core-parent/pom.xml
+++ b/core/core-parent/pom.xml
@@ -54,20 +54,7 @@
 
     <name>Payara Core Parent</name>
 
-    <distributionManagement>
-        <repository>
-            <id>payara-nexus-artifacts</id>
-            <url>https://nexus.payara.fish/repository/payara-artifacts/</url>
-        </repository>
-        <snapshotRepository>
-            <id>payara-nexus-snapshots</id>
-            <url>https://nexus.payara.fish/repository/payara-snapshots/</url>
-        </snapshotRepository>
-    </distributionManagement>
-
     <properties>
-        <!-- core artifacts end up in payara-artifacts repo -->
-        <deploy.skip>false</deploy.skip>
         <jar.manifest>${project.build.outputDirectory}/META-INF/MANIFEST.MF</jar.manifest>
     </properties>
 
@@ -403,15 +390,6 @@
                         </testExcludes>
                     </configuration>
                 </plugin>
-                <plugin>
-                    <groupId>org.apache.maven.plugins</groupId>
-                    <artifactId>maven-deploy-plugin</artifactId>
-                    <version>${maven.deploy.plugin.version}</version>
-                    <configuration>
-                        <retryFailedDeploymentCount>10</retryFailedDeploymentCount>
-                        <skip>${deploy.skip}</skip>
-                    </configuration>
-                </plugin>
 
                 <plugin>
                     <groupId>org.apache.felix</groupId>
diff --git a/core/pom.xml b/core/pom.xml
index 9f2770d0534..6b18561ecca 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -185,7 +185,7 @@
         <!-- build settings -->
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
-        <deploy.skip>true</deploy.skip>
+        <deploy.skip>false</deploy.skip>
         <javadoc.skip>true</javadoc.skip>
 
         <payara.deployment.transformer.version>1.3</payara.deployment.transformer.version>
@@ -215,6 +215,17 @@
         </license>
     </licenses>
 
+    <distributionManagement>
+        <repository>
+            <id>payara-nexus-artifacts</id>
+            <url>https://nexus.payara.fish/repository/payara-artifacts/</url>
+        </repository>
+        <snapshotRepository>
+            <id>payara-nexus-snapshots</id>
+            <url>https://nexus.payara.fish/repository/payara-snapshots/</url>
+        </snapshotRepository>
+    </distributionManagement>
+
     <repositories>
         <!-- Try Maven central first, not last, which happens when omitted here -->
         <repository>
@@ -448,6 +459,15 @@
                         </execution>
                     </executions>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-deploy-plugin</artifactId>
+                    <version>${maven.deploy.plugin.version}</version>
+                    <configuration>
+                        <retryFailedDeploymentCount>10</retryFailedDeploymentCount>
+                        <skip>${deploy.skip}</skip>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
     </build>
diff --git a/pom.xml b/pom.xml
index 0cdae68c48d..73758ad095d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -117,6 +117,13 @@
         </pluginRepository>
     </pluginRepositories>
 
+    <distributionManagement>
+        <repository>
+            <id>payara-nexus-distributions</id>
+            <url>https://nexus.payara.fish/repository/payara-community/</url>
+        </repository>
+    </distributionManagement>
+
     <properties>
         <dynamic.build.properties.version>0.0.1.a2</dynamic.build.properties.version>
 
@@ -150,6 +157,8 @@
         <monitoring-console-process.version>2.0.1</monitoring-console-process.version>
         <monitoring-console-webapp.version>2.0.1</monitoring-console-webapp.version>
         <validation.xml.root>${project.build.outputDirectory}</validation.xml.root>
+
+        <deploy.skip>true</deploy.skip>
     </properties>
 
     <profiles>
@@ -278,25 +287,6 @@
             </build>
         </profile>
 
-        <profile>
-            <!-- only internal modules deployed, so tests can run without Server build built -->
-            <id>deploy-internals</id>
-            <properties>
-                <deploy.skip>false</deploy.skip>
-            </properties>
-
-            <distributionManagement>
-                <repository>
-                    <id>payara-nexus-artifacts</id>
-                    <url>https://nexus.payara.fish/repository/payara-artifacts/</url>
-                </repository>
-                <snapshotRepository>
-                    <id>payara-nexus-snapshots</id>
-                    <url>https://nexus.payara.fish/repository/payara-snapshots/</url>
-                </snapshotRepository>
-            </distributionManagement>
-        </profile>
-
         <profile>
             <id>BuildCore</id>
             <activation>
@@ -390,15 +380,6 @@
                         </testExcludes>
                     </configuration>
                 </plugin>
-                <plugin>
-                    <groupId>org.apache.maven.plugins</groupId>
-                    <artifactId>maven-deploy-plugin</artifactId>
-                    <version>${maven.deploy.plugin.version}</version>
-                    <configuration>
-                        <retryFailedDeploymentCount>10</retryFailedDeploymentCount>
-                        <skip>${deploy.skip}</skip>
-                    </configuration>
-                </plugin>
 
                 <plugin>
                     <groupId>org.apache.felix</groupId>

From 1c907ef6cb99a491fdada450240ba251d99a90bf Mon Sep 17 00:00:00 2001
From: Andrew Pielage <pandrex247@hotmail.com>
Date: Thu, 14 Sep 2023 09:34:18 +0100
Subject: [PATCH 2/2] FISH-7809 Don't unnecessarily deploy repackaged externals

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
---
 appserver/packager/external/pom.xml | 1 -
 appserver/packager/pom.xml          | 1 -
 nucleus/packager/external/pom.xml   | 1 -
 nucleus/packager/pom.xml            | 1 -
 4 files changed, 4 deletions(-)

diff --git a/appserver/packager/external/pom.xml b/appserver/packager/external/pom.xml
index 7c550755783..e861bf10362 100644
--- a/appserver/packager/external/pom.xml
+++ b/appserver/packager/external/pom.xml
@@ -63,7 +63,6 @@
 
     <properties>
         <findbugs.skip>true</findbugs.skip>
-        <deploy.skip>false</deploy.skip>
     </properties>
 
     <modules>
diff --git a/appserver/packager/pom.xml b/appserver/packager/pom.xml
index 78326b15a72..a693fa093ad 100644
--- a/appserver/packager/pom.xml
+++ b/appserver/packager/pom.xml
@@ -175,7 +175,6 @@
         <findbugs.skip>true</findbugs.skip>
         <zip.excludes>**\/META-INF,META-INF\/*</zip.excludes>
         <pkg_proto.py>src/main/resources/pkg_proto.py</pkg_proto.py>
-        <deploy.skip>true</deploy.skip>
     </properties>
     
     <build>
diff --git a/nucleus/packager/external/pom.xml b/nucleus/packager/external/pom.xml
index 13272c74821..364be98df1e 100644
--- a/nucleus/packager/external/pom.xml
+++ b/nucleus/packager/external/pom.xml
@@ -63,7 +63,6 @@
 
     <properties>
         <findbugs.skip>true</findbugs.skip>
-        <deploy.skip>false</deploy.skip>
     </properties>
 
     <modules>
diff --git a/nucleus/packager/pom.xml b/nucleus/packager/pom.xml
index 3286ed6d613..935a43e0372 100644
--- a/nucleus/packager/pom.xml
+++ b/nucleus/packager/pom.xml
@@ -86,7 +86,6 @@
         <temp.modules.dir>${temp.dir}/modules</temp.modules.dir>
         <findbugs.skip>true</findbugs.skip>
         <zip.excludes>**\/META-INF,META-INF\/*</zip.excludes>
-        <deploy.skip>true</deploy.skip>
     </properties>
 
     <modules>