Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra column of pixels from previous slide is showing in Safari with even-numbered window width #43

Closed
jsit opened this issue Mar 5, 2017 · 6 comments

Comments

@jsit
Copy link

jsit commented Mar 5, 2017

The example slider on the home page for the project shows a single column of pixels from the previous slide when going to the next slide. This is only happening for me in Safari, and only when the window is an even number of pixels wide. This doesn't happen at all, for instance, in Chrome.

I don't think it's a bug with this library, I think Safari must just be doing the translate3d math not quite precisely, but I wanted to record the problem here in case others are having it.

Screencast here: http://d.pr/v/DhOT

One solution I've found is to add left and right padding to each slide, which prevents this "bleeding".

@pawelgrzybek
Copy link
Owner

pawelgrzybek commented Mar 7, 2017

Hi Jay.

Thanks for reporting. I knew about some sub-pixel rendering issues but your screenshot definitely helped. I'll take some time to investigate this problem further and let you know when the fix (if possible) is ready.

Thanks a lot and have a nice day.

@pawelgrzybek
Copy link
Owner

Hi @jsit.

I spent some time looking at this issue and there is no way that I can replicate this bug. Any chance to create a CodePen / JSFiddle, JSbin example for me please? If you can provide an info about the browser that the issue occurs it would be really fantastic.

Looking forward to have some info back as I'm really keen to investigate further before next big release. Thanks

@jsit
Copy link
Author

jsit commented Apr 11, 2017

Thanks @pawelgrzybek. I'm also not able to reproduce it in Safari 10.1 on my work MacBook. I'll try again at home (where it was happening) later.

The Siema example page itself was exhibiting this issue, which is why I didn't include a Pen/Fiddle.

@pawelgrzybek
Copy link
Owner

Hi @jsit

Just to let you know that issue has been resolved. It was related with pixel rounding. This is everything that was needed to resolve this issue :)

ec54570#diff-0f98adb017f3c5a836cd2a762834f5b9

Thanks again for reporting and have a great weekend 🍻

@pawelgrzybek
Copy link
Owner

Actually thats better :)

2b568f3#diff-0f98adb017f3c5a836cd2a762834f5b9

@jsit
Copy link
Author

jsit commented Apr 13, 2017

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants