From 32762197d12ced0724de1eb940295bc274227508 Mon Sep 17 00:00:00 2001 From: tcchawla Date: Fri, 19 Jan 2024 16:49:00 -0500 Subject: [PATCH] fixed review comments Signed-off-by: tcchawla --- .github/workflows/test_arm64.yaml | 15 +-------------- .github/workflows/test_template.yaml | 5 +++-- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/.github/workflows/test_arm64.yaml b/.github/workflows/test_arm64.yaml index 3ec155ad0b9e..e9db42402d87 100644 --- a/.github/workflows/test_arm64.yaml +++ b/.github/workflows/test_arm64.yaml @@ -6,17 +6,4 @@ jobs: uses: ./.github/workflows/test_template.yaml with: runs-on: actuated-arm64-8cpu-8gb - targets: "['linux-arm64-unit-test-4-cpu-race']" - - coverage: - needs: - - test-linux-arm64-cpu-race - runs-on: actuated-arm64-8cpu-8gb - steps: - - uses: actions/checkout@v4 - - id: goversion - run: echo "goversion=$(cat .go-version)" >> "$GITHUB_OUTPUT" - - uses: actions/setup-go@v5 - with: - go-version: "1.21.6" - - run: make test + targets: "['linux-arm64-unit-4-cpu-race']" diff --git a/.github/workflows/test_template.yaml b/.github/workflows/test_template.yaml index 1129726a17ce..9bce0b5d371a 100644 --- a/.github/workflows/test_template.yaml +++ b/.github/workflows/test_template.yaml @@ -9,7 +9,7 @@ on: targets: required: false type: string - default: "['linux-unit-test-1-cpu', 'linux-unit-test-4-cpu']" + default: "[]" permissions: read-all jobs: @@ -27,6 +27,7 @@ jobs: - env: TARGET: ${{ matrix.target }} run: | + go clean -testcache case "${TARGET}" in linux-amd64-unit-4-cpu-race) GOARCH=amd64 PASSES='unit' RACE='true' CPU='4' ./scripts/test.sh -p=2 @@ -34,7 +35,7 @@ jobs: linux-386-unit-1-cpu) GOARCH=386 PASSES='unit' RACE='false' CPU='1' ./scripts/test.sh -p=4 ;; - linux-arm64-unit-test-4-cpu-race) + linux-arm64-unit-4-cpu-race) GOARCH=arm64 PASSES='unit' RACE='true' CPU='4' ./scripts/test.sh -p=2 ;; *)