Corrects bug in type discovery. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons I don't understand, TypeScript is finding `index.ts` instead of `index.d.ts` when it goes looking for types for `index.js`. This is despite the docs saying that it will find `index.d.ts`. https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package None the less, this can be resolved by just being explicit, as done in this PR.
|
Any chance we could get a release cut with this included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I don't understand, TypeScript is finding
index.tsinstead ofindex.d.tswhen it goes looking for types forindex.js. This is despite the docs saying that it will findindex.d.ts. https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-packageNone the less, this can be resolved by just being explicit, as done in this PR.
I asked about this in an ongoing thread on the issue, hopefully I'll get some clarity on why the defaults aren't working here:
microsoft/TypeScript#40426 (comment)