Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure caused by regression in node.js path module in 5.7.0 #442

Closed
es128 opened this issue Feb 25, 2016 · 2 comments
Closed

Test failure caused by regression in node.js path module in 5.7.0 #442

es128 opened this issue Feb 25, 2016 · 2 comments

Comments

@es128
Copy link
Contributor

es128 commented Feb 25, 2016

nodejs/node#5389

λ nvm use 5
Now using node v5.7.0

λ node
> path.relative('/tmp/1/2/3', '/tmp/1/2')
'../../2'

λ nvm use 5.6
Now using node v5.6.0

λ node
> path.relative('/tmp/1/2/3', '/tmp/1/2')
'..'
  1) chokidar fs.watchFile (polling) getWatched should set keys relative to cwd & include added paths:

      Uncaught AssertionError: expected { Object (../../test-fixtures, ., ...) } to deeply equal { Object (., .., ...) }
      + expected - actual

           "change.txt"
           "subdir"
           "unlink.txt"
         ]
      -  "../../test-fixtures": [
      +  "..": [
           "1"
         ]
         "subdir": []
       }

      at Assertion.assertEqual (node_modules/chai/lib/chai/core/assertions.js:485:19)
      at Assertion.ctx.(anonymous function) [as equal] (node_modules/chai/lib/chai/utils/addMethod.js:41:25)
      at FSWatcher.<anonymous> (test.js:1563:48)
@paulmillr
Copy link
Owner

they should fix it in 5.7.1 nodejs/node#5464

@es128
Copy link
Contributor Author

es128 commented Mar 1, 2016

Yup, just wanted this open to track it until the release actually happens. Not a big deal though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants