-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket stuck in the Connecting state #842
Comments
Thank you for reporting, I added the missing state change in #845 which will indeed solve the main issue with WebSockets stuck in connecting state with OpenSSL. The second issue with WinSock error 10038 (i.e. WSAENOTSOCK) in |
The second issue is just a result of the first. Sockets from the failed connections are still registered in |
This is still a bug on Windows that could be triggered in another way. I'm pushing a workaround to prevent failure when |
Looks like a
changeState(State::Failed);
is required here:libdatachannel/src/impl/tlstransport.cpp
Lines 721 to 723 in 3c46659
Found on version: 0.18.2 with OpenSSL
How to reproduce: run the WebSocket server with TLS enabled and autogenerated certificate. Try to connect to the server from Firefox or Chrome. Since modern browsers don't trust self-signed certificates by default, the connection will be rejected.
Observed behavior: client WebSocket stuck in the Connecting state
Expected behavior: onError or onClosed events are called.
If continued attempts to establish a connection to the server, all the sockets still be registered in the PollService. At some point, PollService will fail. I tested on my Windows system, and ~70 connections were enough.
The text was updated successfully, but these errors were encountered: