Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaHandler of PeerConnection is never called #801

Closed
ognkrmms opened this issue Feb 10, 2023 · 1 comment · Fixed by #802
Closed

MediaHandler of PeerConnection is never called #801

ognkrmms opened this issue Feb 10, 2023 · 1 comment · Fixed by #802
Labels
bug Something isn't working

Comments

@ognkrmms
Copy link
Contributor

Hi,

I have a class called CCResponder derived from MediaHandler. This class is supposed to take care of receiver reports. In the streamer example, I added the following line in the createPeerConnection function:

pc->setMediaHandler(std::make_shared<CCResponder>());

On the master branch, There is no problem in the commit f9fc064 but starting from the commit 0b98d7a, CCResponder ::incoming is never called. I saw this behavior on both Windows and Linux machines. I can confirm there are receiver reports via Wireshark.

Any guidance is appreciated.

@paullouisageneau paullouisageneau added the bug Something isn't working label Feb 10, 2023
@paullouisageneau
Copy link
Owner

Indeed, #765 introduced a regression by breaking SRTCP profile setting on master branch.

This should be fixed by #802.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants