Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Upload Comments to Google Sheets #217

Open
jeffbcross opened this issue Aug 29, 2019 · 1 comment
Open

Feature Request: Upload Comments to Google Sheets #217

jeffbcross opened this issue Aug 29, 2019 · 1 comment

Comments

@jeffbcross
Copy link

Suppose I'm running pwmetrics in a post-merge CI job to track my app's performance over time. I'd like to associate each row of data with the git commit of the code being tested, so I can pinpoint where a regression (or improvement) was introduced.

If I could have an additional option in the sheets options for a comments field that would accept a string or function, I could accomplish this as follows:

module.exports = {
  sheets: {
    type: 'GOOGLE_SHEETS',
    options: {
      comments: () => require('child_process').execSync('git rev-parse --short HEAD').toString()
    }
};

There could be more advanced use cases that would benefit from passing in metadata to the function, but for my particular use case, this simple start would be fine.

I'd be happy to contribute a PR if the feature is approved!

@denar90
Copy link
Collaborator

denar90 commented Sep 3, 2019

Hi @jeffbcross, comments feature sounds cool. Great idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants