-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for multiple URLs #63
Comments
(cc @spicyj as the original author of that) |
I'm actually considering removing the ability to capture multiple urls in one webkit2png instance - it makes the code a lot messier, I'm fairly sure it's the source of a lot of bugs like this, it makes error handling difficult for calling scripts (because the entire process crashes when one url breaks) and it's not much easier than just using a bash for loop or similar. On the other hand, it is slightly slower (although I haven't benchmarked this). Thoughts? |
I always used to capture one at a time, so this wouldn't upset me. |
As discussed in paulhammond#63, webkit2png might be better capturing just one URL at a time.
I'd say we should strip out multiple URL support. The complexity isn't worth the limited functionality. It would be easy enough to add another script that takes a bunch of URLs and any webkit2png options and launches n processes, if someone really wanted out-of-the-box functionality. |
@norm: Could you please provide more detail on what you commented? I have a need to process multiple URLs without the added slowdown of re-initializing WebKit. Thanks. |
Closing in favor of #109 |
When capturing multiple URLs from one instance of webkit2png, the following error occurs:
Have tracked it down to the new Webkit2PngScriptBridge. With the code for that commented out, it works fine.
The text was updated successfully, but these errors were encountered: