Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper.md attributions #7

Closed
rgiordan opened this issue Oct 20, 2017 · 3 comments
Closed

paper.md attributions #7

rgiordan opened this issue Oct 20, 2017 · 3 comments

Comments

@rgiordan
Copy link

openjournals/joss-reviews#425

The review has the following checkbox, which is not fulfilled by the current paper.md: "Authors: Does the paper.md file include a list of authors with their affiliations?" Somewhat relatedly, in my opinion, it might be made clearer in the paper that you're providing a shiny frontend to bnlearn rather than implementing the learning algorithms yourself. Although you do very prominently say it's "powered" by bnlearn, I feel it is best to be as clear as possible with author attribution!

@paulgovan
Copy link
Owner

Agreed as well. Added (fixed) affiliation and attempted to provide clear credit to the package.

@katyhuff
Copy link

Just a note, in order to communicate that something is fixed, it's common to comment as you have above. However, that comment often includes a link to either a PR, or the merged commit that fixes the issue. In this case, I think it was probably this commit (fb54626#diff-60426898a850f648abeda63b199792cc) that solved the issue.

@paulgovan
Copy link
Owner

paulgovan commented Nov 20, 2017

Yes, please reference commits fb54626 and 7b29b4d on this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants