Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing hybrid Angular 1+2 app #72

Closed
andrewg78 opened this issue Aug 24, 2018 · 4 comments
Closed

Testing hybrid Angular 1+2 app #72

andrewg78 opened this issue Aug 24, 2018 · 4 comments

Comments

@andrewg78
Copy link

andrewg78 commented Aug 24, 2018

I'm having issue to test a hybrid app
I do not have root element in my ng1 app so I do not know how to use RootSelector.
image

Here is the link to the same issue with some samples on plunker
angular/protractor#2944
angular/protractor#3238

@paul-hammant
Copy link
Owner

Yeah, add a contrived root attribute like <div my-ng-root .... />

@paul-hammant
Copy link
Owner

Andrew?

@andrewg78
Copy link
Author

andrewg78 commented May 17, 2019

Hi Paul.
I think I found root cause of my issue, but have no clue how to resolve it.
There is an older version of the app under test which works fine with the waitForAngularRequestsToFinish method.
I do not have to set root selector and it works just fine.
The newer version has NO ng-app attribute, so I guess this is the reason why this wait method doesn't work.
Edited here:
I keep digging on that issue and I understand more now.
I guess problem is related to NgUpgrade and bootstrapping old Angular app to newer version.
Here is some info.
angular/protractor#4290
ui-router/angular-hybrid#39 (comment)

@paul-hammant
Copy link
Owner

Can the dev team help you with here? Cooperating for sake of testability by adding a more convention ng-app root ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants