feat(pipelines): add support for collapsible groups #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
added
enhancement
|
I'll pull this down and take a look. Thanks for tagging me. |
jenny-s51
force-pushed
the
iss153
branch
2 times, most recently
from
6a9f246 to
f49c3c5
Compare
jenny-s51
changed the title
packages/module/src/pipelines/components/groups/PipelinesDefaultGroup.tsx
Outdated
Show resolved
Hide resolved
packages/module/src/pipelines/components/groups/PipelinesDefaultGroup.tsx
Outdated
Show resolved
Hide resolved
styling wip update classnames wip add proper styling, wip hover clean up unused vars, add drop shadow to action icon remove css class to fix build fix :hot build add correct styling to collapsible groups revert action label styling to default, adds isIconExternal prop add collapsible groups to subgroups layout add ref to revert to default label styling add withSelection, update padding clean up css use PF vars for css styles updates per Jeff, WIP remove data from group nodes PR feedback from Jeff: add correct params to PipelinesDefaultGroupExpanded, wrap label with layer add props to fix build fix label position remove custom css in favor of existing pf styles PR feedback from Jeff, apply pill styling to collapsed group fix build
jeff-phillips-18
approved these changes
Mar 26, 2024
jessiehuff
approved these changes
Mar 26, 2024
|
🎉 This PR is included in version 5.3.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Will close #153.
WIP / help wanted:
Recursive selection of subgroups when parent group is selected☑️ Discussed with design, selection to be replaced with expand action animation to indicate expanded state
Draw location and edge anchor points of collapsed pipeline group☑️ Fixed by @jeff-phillips-18
Description
Adds support for collapsible pipelines groups and related styling as discussed with @andrew-ronaldson and @jeff-phillips-18
Type of change
Surge preview:
https://expand-collapse.surge.sh/