feat(label): add support for top label position in groups #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikjeeyar
force-pushed
the
group-label-position
branch
2 times, most recently
from
c0917f2 to
0144981
Compare
|
@karthikjeeyar |
karthikjeeyar
force-pushed
the
group-label-position
branch
2 times, most recently
from
c075d3f to
c753841
Compare
karthikjeeyar
force-pushed
the
group-label-position
branch
from
c753841 to
f8ffa3d
Compare
jeff-phillips-18
approved these changes
Feb 14, 2024
nicolethoen
reviewed
Feb 14, 2024
karthikjeeyar
force-pushed
the
group-label-position
branch
from
f8ffa3d to
7994ec5
Compare
jenny-s51
reviewed
Feb 15, 2024
There was a problem hiding this comment.
This is looking great @karthikjeeyar!
For the pipeline groups I'm seeing the titles appearing a bit higher than expected...
packages/module/src/pipelines/components/groups/DefaultTaskGroup.tsx
Outdated
Show resolved
Hide resolved
karthikjeeyar
force-pushed
the
group-label-position
branch
from
7994ec5 to
c2e26cc
Compare
karthikjeeyar
force-pushed
the
group-label-position
branch
2 times, most recently
from
5ac8475 to
a4e2559
Compare
karthikjeeyar
force-pushed
the
group-label-position
branch
from
a4e2559 to
a3c2452
Compare
jenny-s51
approved these changes
Feb 15, 2024
|
🎉 This PR is included in version 5.3.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #
#139
Description
Adds
toplabel position in group nodeType of change
Screen shots / Gifs for design review
Collapsed Group:
Expanded Groups:
Pipeline task groups:
.