chore(deps): remove tippy-react dependency #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://patternfly-react-pr-2505.surge.sh |
seanforyou23
force-pushed
the
tooltip-popover-refactor
branch
from
0aabd74 to
6e3947a
Compare
seanforyou23
force-pushed
the
tooltip-popover-refactor
branch
from
6e3947a to
088794a
Compare
redallen
previously approved these changes
Jul 16, 2019
seanforyou23
force-pushed
the
tooltip-popover-refactor
branch
from
088794a to
9c14c21
Compare
redallen
approved these changes
Jul 17, 2019
jschuler
approved these changes
Jul 18, 2019
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This PR removes the dependency on @tippy.js/react and brings this functionality in-house as a new helper component called
PopoverBase. We ran into issues with the latest version of @tippy.js/react (2.x) and decided that best path forward for us is bringing this module in-house. Of course, we're still using tippy.js core so we're basically swapping @tippy.js/react for tippy.js as a dependency.Additional issues: N/A
This is the first of putting back into place work that was abandoned in #2326 and #2395
There will be follow up PR's for the remaining work - will link them together in the descriptions for easy tracking.