Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs - add border-bottom variation for secondary tabs, update demo #7259

Closed
mcoker opened this issue Apr 18, 2022 · 0 comments · Fixed by #7311
Closed

Tabs - add border-bottom variation for secondary tabs, update demo #7259

mcoker opened this issue Apr 18, 2022 · 0 comments · Fixed by #7311
Assignees
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented Apr 18, 2022

Issue: patternfly/patternfly#4753
PR: patternfly/patternfly#4774

  • Adds .pf-m-border-bottom to add a bottom border to secondary tabs.
  • Updates secondary tabs in "Open tabs with secondary tabs" demo
  • Also see if we can match the structure in the core demo. We need to remove the extra space between the primary and secondary tabs, and make sure the secondary tabs extends to the edge of the container with an inset, so the border goes to the edge of the container.
    • If we can't match the core structure, you should be able to do that with the current example by:
      • Add .pf-m-no-padding to page section that wraps secondary tabs and tab content
      • Add .pf-m-page-insets to secondary tabs (and remove .pf-m-inset-none)
      • Add .pf-m-padding to the .pf-c-tab-content__body element that wraps the "Pod details" content
      • Side note - the first tab content element in this demo is in it's own div, and the others are in another, and those divs are wrapped in a flex layout - could the flex layout just be removed and the tab content elements all be adjacent to one another? Only one should show at a time.
@mcarrano mcarrano added this to the 2022.06 milestone Apr 19, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Apr 20, 2022
@wise-king-sullyman wise-king-sullyman moved this from Not started to In Progress in PatternFly Issues Apr 27, 2022
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Apr 28, 2022
Repository owner moved this from PR Review to Done in PatternFly Issues May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants