Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DualListSelectorControl tooltips remain visible after VO blur #7021

Closed
Tracked by #8700
thatblindgeye opened this issue Mar 8, 2022 · 1 comment · Fixed by #9901
Closed
Tracked by #8700

DualListSelectorControl tooltips remain visible after VO blur #7021

thatblindgeye opened this issue Mar 8, 2022 · 1 comment · Fixed by #9901
Assignees
Labels

Comments

@thatblindgeye
Copy link
Contributor

thatblindgeye commented Mar 8, 2022

Describe the issue. What is the expected and unexpected behavior?
The tooltips on the Dual List Selector component's controls do not currently get read by screen readers; whether this should be fixed since most likely the tooltip will match the aria-label of the button may require additional input. UPDATE: this portion of the issue looks to be resolved.

The tooltips also do not disappear immediately when navigating via VO (you have to navigate outside the button controls area it looks like, rather than simply navigating away from the button that has the tooltip currently displayed).

If the tooltips should be announced by screen readers, even if the contents of them matches the button's aria-label, then this might be similar to PR #6940 in that instead of using the Tooltip's reference prop, it should instead act as a wrapper around the DualListSelectorControl inner button element.

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.

Go to the PatternFly Dual List Selector page and use VO on the With Tooltips example. Notice that the buttons between the two option lists do not have tooltips announced by screen readers, nor do they immediately disappear after moving focus away from a button.

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
Could be considered a bug

@thatblindgeye
Copy link
Contributor Author

Updates made in PR #7332 look to have resolve the issue of tooltips not getting announced. However, there is still a small issue where when navigating via VO controls from an active button to a disabled button, the tooltip remains visible. See video below:

Dual.List.Selector.Tooltip.Visible.mov

@thatblindgeye thatblindgeye changed the title DualListSelectorControl tooltips not read by VO DualListSelectorControl tooltips remain visible after VO blur May 10, 2022
@nicolethoen nicolethoen self-assigned this Sep 23, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Sep 23, 2022
@nicolethoen nicolethoen removed their assignment Feb 15, 2023
@mfrances17 mfrances17 self-assigned this Oct 10, 2023
@mfrances17 mfrances17 moved this from Not started to In Progress in PatternFly Issues Dec 19, 2023
@mfrances17 mfrances17 moved this from In Progress to PR Review in PatternFly Issues Dec 20, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants