Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown - menuAppendTo is missing from docs #6985

Closed
mcoker opened this issue Feb 28, 2022 · 2 comments · Fixed by #7173 or #7435
Closed

Dropdown - menuAppendTo is missing from docs #6985

mcoker opened this issue Feb 28, 2022 · 2 comments · Fixed by #7173 or #7435
Assignees
@jenny-s51
Labels
Documentation 📝
Milestone
2022.07

Comments

@mcoker
Copy link
Contributor

mcoker commented Feb 28, 2022

In the dropdown component docs, we have an append menu document body example that uses menuAppendTo, but that prop is missing from the docs. I checked the select component docs and it's listed there. I'm not sure what all components support that prop but it might be good to double check the docs for those components, too.
@mcarrano mcarrano added this to the 2022.05 milestone Mar 11, 2022
@jenny-s51 jenny-s51 self-assigned this Mar 29, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Mar 29, 2022
@jenny-s51 jenny-s51 mentioned this issue Apr 4, 2022
Merged
@nicolethoen nicolethoen moved this from Not started to PR Review in PatternFly Issues Apr 4, 2022
Repository owner moved this from PR Review to Done in PatternFly Issues Apr 13, 2022
@tlabaj tlabaj reopened this May 10, 2022
@tlabaj tlabaj removed this from the 2022.05 milestone May 10, 2022
@tlabaj
Copy link
Contributor

tlabaj commented May 10, 2022

@mcarrano we had to revert the PR that closed this. Can you reprioritize this issue please.

@mcarrano mcarrano moved this from Done to Not started in PatternFly Issues May 10, 2022
@mcarrano mcarrano added this to the 2022.07 milestone May 10, 2022
@nicolethoen
Copy link
Contributor

The product was relying on ToggleMenuBaseProps since it was publicly exposed.
For more information see: https://github.com/keycloak/keycloak-admin-ui/pull/2613

@nicolethoen nicolethoen moved this from Not started to In Progress in PatternFly Issues May 12, 2022
@jenny-s51 jenny-s51 added the Breaking change 💥 this change requires a major release and has API changes. label May 16, 2022
@jenny-s51 jenny-s51 mentioned this issue May 17, 2022
Merged
@jenny-s51 jenny-s51 removed the Breaking change 💥 this change requires a major release and has API changes. label May 17, 2022
@nicolethoen nicolethoen moved this from In Progress to PR Review in PatternFly Issues May 18, 2022
@jenny-s51 jenny-s51 mentioned this issue May 18, 2022
Closed
Repository owner moved this from PR Review to Done in PatternFly Issues May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenny-s51 jenny-s51

Labels
Documentation 📝
Projects
PatternFly Issues
Archived in project
Milestone
2022.07
5 participants
@mcarrano @nicolethoen @jenny-s51 @mcoker @tlabaj