Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drilldown menu: unnecessary scroll bar in sub menus #6842

Closed
nicolethoen opened this issue Jan 20, 2022 · 0 comments · Fixed by #7070
Closed

Drilldown menu: unnecessary scroll bar in sub menus #6842

nicolethoen opened this issue Jan 20, 2022 · 0 comments · Fixed by #7070
Assignees
Milestone

Comments

@nicolethoen
Copy link
Contributor

Each MenuList has top and bottom padding.
In the case of a Drilldown menu, each sub level of a MenuList is rendered as a child of the MenuList. It results in nested MenuLists. To prevent the top and bottom padding from stacking (and growing too large). MenuLists which are children of other MenuLists have their padding zeroed out (see the screen shot below).

Screen Shot 2022-01-20 at 12 48 34 PM

This causes for the calculation of the height of the Menu in MenuContent.tsx's refCallback around line 21 to be incorrect. The sub MenuList's clientHeight does not include the padding of it's parent MenuList so it thinks that the rendered sub menu is shorter than it actually is, causing the contents to overflow and create a scrollbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants