-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application Launcher breaks when fragments or wrappers used #5490
Labels
Comments
Part of the epic: #6014 |
6 tasks
It sounds like this is no longer an issue with the new recommended solution for Application Launcher. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue. What is the expected and unexpected behavior?
Due to the fact the Dropdown keyboard interaction is handled based on their implicit index (being array children), wrapping dropdown elements in react fragments or other elements breaks the keyboard navigation. If the child is wrapped in a fragment, its implicit index is
-1
. If it's not wrapped, it will get the proper index based on its position in the array. We should make index a real prop on the ApplicationLauncherItem and give sequential keyboard access to increment the index by 1.Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.
Try to wrap any element in the dropdown with a react fragment, and you will notice that none of the keyboard interactions work anymore.
Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
Bug - workaround is to either remove the react fragment/wrapper or to add an index that overrides the implicit index
What is your product and what release version are you targeting?
First noticed in OpenShift.
The text was updated successfully, but these errors were encountered: