Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: investigate how to improve screen reader experience and update #5383

Open
10 of 13 tasks
jessiehuff opened this issue Jan 27, 2021 · 2 comments
Open
10 of 13 tasks
Labels

Comments

@jessiehuff
Copy link
Contributor

jessiehuff commented Jan 27, 2021

Describe the issue. What is the expected and unexpected behavior?
I've noticed that our tooltip examples aren't always announced in VO. The only example that has solidly worked when I've tested lately has been the Options example, and my theory behind this is the placement in the DOM. We should investigate how we can make sure that our tooltips work in a screen reader (I'd like us to ideally also test this in other screen readers as well like NVDA and JAWS). I'm wondering if we can treat it similarly to how we treat alerts and add an aria-live to let screen readers know where the content will be updated and make sure it's aware of these changes.

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.
Open VO and test our tooltip examples. In Chrome, the first example works along with the Options example. In Safari, only the Options example works. I'd like to make sure all implementations of tooltip work so that we can ensure our products' tooltips work in their implementations.

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
bug

Remaining issues in this epic:

  • Tooltips for disabled radio #3791 - Still needs to be completed. The linked issue has a few options with their own pros. Wrapping the entire Radio component in a Tooltip will result in the tooltip being centered above the entire Radio, which visually may not be the desired effect if the Radio doesn't have a lot of content, while wrapping just the radio input in a Tooltip provides a smaller area for users to trigger it.
  • Bug - MenuItem- Tooltips on MenuItems aren't being announced #9517 - MenuItem's aren't having Tooltips applied/announced correctly
  • Bug - [Dropdown] - [Dropdown tooltips are not accessible by JAWS and NVDA] #7584 - From @thatblindgeye: In testing the dropdown component again, this time both with JAWS and NVDA, I was able to get the tooltips in the Basic example to get announced in both screen readers. This may require another test from at least 2 people to confirm which behavior is more reliable. UPDATE 8/17/2023: the deprecated Dropdown still works for me with NVDA/JAWS, however the new implementation suffers the same issue as mentioned in the above issue 9517 since it's using Menu under the hood
  • DualListSelectorControl tooltips remain visible after VO blur #7021 - This may not require completion due to the refactor that will be done for the Dual List Selector component. UPDATE 8/17/2023: This can be resolved by removing the disabled attribute from the controls that have it, so that instead they're only aria-disabled. The tooltip does de-render once focus is moved out of this controls group, though.

No longer applicable:

Completed issues:

@nicolethoen
Copy link
Contributor

be sure our examples meet a11y standards. i.e. they dont put tooltips on static elements

@nicolethoen
Copy link
Contributor

tooltips which change dynamically need to be accessible: #1655

@mcarrano mcarrano added this to the 2022.02 milestone Oct 8, 2021
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Nov 4, 2021
@mcarrano mcarrano modified the milestones: 2022.02, 2022.03, 2022.04 Feb 11, 2022
@mcarrano mcarrano modified the milestones: 2022.04, 2022.05 Mar 4, 2022
@mcarrano mcarrano modified the milestones: 2022.05, 2022.06 Apr 18, 2022
@mcarrano mcarrano modified the milestones: 2022.06, 2022.07 Apr 28, 2022
@mcarrano mcarrano moved this from Not started to In Progress in PatternFly Issues May 10, 2022
@mcarrano mcarrano modified the milestones: 2022.07, 2022.08 May 19, 2022
@mcarrano mcarrano modified the milestones: 2022.08, 2022.10 Jun 9, 2022
@mcarrano mcarrano modified the milestones: 2022.10, 2022.11 Jul 1, 2022
@mcarrano mcarrano modified the milestones: 2022.11, 2022.12 Jul 29, 2022
@mcarrano mcarrano modified the milestones: 2022.12, 2022.13 Aug 19, 2022
@mcarrano mcarrano modified the milestones: 2022.13, 2022.14, 2023.02 Sep 23, 2022
@mcarrano mcarrano modified the milestones: 2023.02, 2022.16 Oct 26, 2022
@mcarrano mcarrano modified the milestones: 2022.16, 2023.01 Nov 11, 2022
@mcarrano mcarrano modified the milestones: 2023.01, Prioritized Backlog Nov 29, 2022
@kmcfaul kmcfaul removed the Epic label Oct 25, 2024
@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

5 participants