Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Keyboard Interaction #3108

Closed
jessiehuff opened this issue Oct 10, 2019 · 3 comments
Closed

Accessibility Keyboard Interaction #3108

jessiehuff opened this issue Oct 10, 2019 · 3 comments
Labels
A11y Breaking change 💥 this change requires a major release and has API changes.

Comments

@jessiehuff
Copy link
Contributor

jessiehuff commented Oct 10, 2019

Ultimate goals:

  • To have consistent keyboard behavior across similar components
  • Have keyboard behavior documented for consumers/contributors
  • Avoid regressions

Updating Components:

  • Component behaviors should be based off of Design Documentation
  • Current state of components has been audited, current behaviors are documented and need updated based on best practices
  • Each time we fix an interaction, a test should be included to prevent a regression
  • Component behaviors that could use improvement are listed below

Testing:

  • Each time we fix an interaction, a test should be included to prevent a regression
  • Test framework (Cypress) has already been set up; it’s a matter of enabling tests to run and reducing the amount of time it takes to test.
  • Design Documentation can be used as a blueprint for creating the tests
  • Also investigate testing with Firefox/Chrome (and possibly other browsers)- different browsers tend to have different behaviors

Component Behaviors:

This section captures any keyboard behavior within the component that doesn’t currently meet accessibility expectations
** NOTE: ** Any issue that is created for fixing the components below should include creating tests as part of the acceptance criteria

Dropdown:

Dropdown Panel:

Application Launcher (uses Dropdown and will likely be impacted by Dropdown updates):

Context Selector:

Options Menu (uses Dropdown and will likely be impacted by Dropdown updates):

Pagination (uses Dropdown and will likely be impacted by Dropdown updates):

Select:

@nicolethoen
Copy link
Contributor

We will be refactoring the components to consume the Menu component to standardize interactions across similar components. Finishing the refactor process will be a breaking change.

@tlabaj tlabaj added this to the Breaking Changes milestone Oct 7, 2021
@nicolethoen
Copy link
Contributor

This whole epic may be addressed when a refactor epic is completed: #6014

@nicolethoen nicolethoen moved this to Needs a milestone in PatternFly Issues Nov 4, 2021
@nicolethoen nicolethoen moved this from Needs a milestone to Pending discussion in PatternFly Issues Nov 4, 2021
@nicolethoen nicolethoen moved this from Pending discussion to Breaking change in PatternFly Issues Nov 4, 2021
@nicolethoen
Copy link
Contributor

This can be considered a duplicate of #6014 since all dropdown menus will use the same Menu and/or Panel components under the hood, they will be using the same interaction patterns.

Repository owner moved this from Breaking change to Done in PatternFly Issues Sep 23, 2022
@tlabaj tlabaj removed this from the Breaking Changes milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Breaking change 💥 this change requires a major release and has API changes.
Projects
Archived in project
Development

No branches or pull requests

3 participants