What was the reason for preventing scroll on this focus call? This focus call should only be called when the menu toggle is closed via Escape or Tab key (or whatever array of keys is passed to onOpenChangeKeys), in which case I think it makes sense that we scroll the page back to whatever item (the menu toggle) has focus.

Imagining a scenario where the Dropdown/menu has a lot of items on a page, or the menu toggle is just scrolled out of view, and focus is on the last item. Pressing Escape or Tab should close the dropdown and focus the menu toggle, but if the menu toggle isn't in view then it may be confusing where the keyboard focus went.

I was still seeing the described problem on menudropdowns on filter views without the above change.
Why this is being triggered on multi-select components I don't know.
With the other fix in place, and this one not.
The same behaviour below was occurring:

Just to confirm, this toggleRef...focus() line is being called when the menu is opened and is causing the scroll jump effect to occur as shown in the video above? Could you share the code of the Select being used that is showing this behavior to test out? I wouldn't expect this line to cause the scroll jump bug to trigger, but could definitely just be something odd going on unexpectedly.

This is the above component.

This is the wrapper I've built to contain the madness that is the patternfly Select component. 😆

So I tried mimicking the setup from both files linked above just within a PatternFly example (wasn't able to get the repo linked in the above files running locally), and I'm not able to reproduce the jump scroll when simply removing the preventScroll option from this toggleRef.focus call of the Select component. May not be an exact 1:1 mimic, and it could also be a difference between the PatternFly workspace and yours, but as far as I can tell reverting this specific line in the changed files shouldn't cause that jump scroll bug when the menu is opened.

Personally I would opt to remove the options being passed to the toggleRef.focus() calls in these files (but keep the option in the other focus calls, i.e. firstElement...focus()), as the expected behavior should be that the page will scroll back to where the MenuToggle receives focus upon the Menu being closed via keyboard. Then if the jump scroll bug is still occurring with the rest of these updates merged in, we could revisit again to investigate further or add the options in as you did originally here.

How did you go about testing the updates in this PR in your product running locally? And you can confirm that reverting the toggleRef.current?.focus({preventScroll:true}); lines in this PR back to just toggleRef.current?.focus(); (but keeping all other changes) causes the bug to still occur when clicking on a MenuToggle to open the select/dropdown/menu?

How did you go about testing the updates

The other component changes were not tested; the copied logic matched and thus I added the changes as I presumed they would be desired.

How did you go about testing the updates in this PR

I simply made the changes to the patternfly components in node_modules > patternfly, and rebuilt.

Personally I would opt to remove the options being passed to the toggleRef.focus()

This is fine, I'll either use another component or find another way to prevent the behaviour.
In my mind, this is a bug needing a fix, but there's no need to force all to subscribe to this.

can confirm that reverting the toggleRef.current?.focus({preventScroll:true})

I'll test again today

Hey @Andrewgdewar , just wanted to check in on if you were able to test the above?

Also wanted to clarify in case I might be misinterpreting the issue here. Can you confirm between the foilowing which you originally meant in regards to this toggleRef...focus call needing the preventScroll option?

1. When the toggleRef focus call does NOT have the preventScroll option passed in, the jump scroll bug still occurs when the menu/select/drodown is opened
2. Or, were you saying that you believe that we shouldn't scroll the page when the menu/select/dropdown is closed and the MenuToggle (toggleRef in this case) receives focus?