Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages do not specify a type field #10831

Open
Tracked by #10833
jonkoops opened this issue Aug 3, 2024 · 2 comments
Open
Tracked by #10833

Packages do not specify a type field #10831

jonkoops opened this issue Aug 3, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@jonkoops
Copy link
Contributor

jonkoops commented Aug 3, 2024

Packages in the workspaces should set the type field in the package.json file. If this field is not set Node.JS may attempt to detect the package type causing a small performance hit. Ideally this field is set to `"type": "module" to indicate an ESM-first approach.

This is part of a series of issues resulting from publication linting introduced under #10764

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 3, 2024
@jonkoops jonkoops changed the title Packages do not specify a type Packages do not specify a type field Aug 3, 2024
@tlabaj tlabaj added the Post v6 label Aug 27, 2024
@tlabaj tlabaj moved this from Needs triage to In Progress in PatternFly Issues Aug 27, 2024
@tlabaj tlabaj added this to the Penta final release milestone Aug 27, 2024
@tlabaj tlabaj removed the Post v6 label Aug 27, 2024
@kmcfaul kmcfaul added P1 ⭐ and removed P1 ⭐ labels Sep 11, 2024
@tlabaj tlabaj added the Post v6 label Sep 25, 2024
@tlabaj tlabaj modified the milestones: Penta final release, 2024.Q4 Sep 25, 2024
@tlabaj tlabaj modified the milestones: 2024.Q4, 2025.Q1 Nov 5, 2024
Copy link

github-actions bot commented Jan 6, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@jonkoops
Copy link
Contributor Author

jonkoops commented Jan 6, 2025

@tlabaj can this issue be pinned?

@tlabaj tlabaj added Pinned and removed wontfix labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

3 participants