fix: updated base template to handlebars #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous syntax might have been fine for mustache, but we should both explicitly use the block helpers as well as mind the context of variables within each helpers.
from mustache to handlebars; wouldn't hurt …
This reverts commit 7def87d.
|
good catch |
JosefBredereck
approved these changes
Dec 30, 2022
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* fix: we need to update that template to handlebars the previous syntax might have been fine for mustache, but we should both explicitly use the block helpers as well as mind the context of variables within each helpers. * chore: additionally updating the template type from mustache to handlebars; wouldn't hurt … * Update index.html * fix: this ones actually an iteration * Revert "fix: this ones actually an iteration" This reverts commit 7def87d. * fix: we actually need to the previous declaration here * chore: previous formatting * chore: changed my mind again …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1462
Summary of changes:
{{#) might have been fine for mustache, but we should both explicitly use the block helpers (like e.g.{{#each,{{#withor{{#if) as well as (elsewhere causing the bug described in the linked issue) mind the context of variables within each helper (navigated one level to the top by{{ ../patternPartial }}within{{#each …}}).scripttag from mustache to handlebars, wouldn't hurt …