routeChangeComplete not correctly configured with useRouter

[kylehotchkiss]

Currently routeChangeComplete event listener is not connected to the useRouter() hook: https://github.com/patronage/bubs-next/blob/main/website/src/pages/_app.js#L22-L34

I found that it wasn't firing for me on page changes. I adjusted the syntax to follow the routeChangeComplete syntax in Next docs and then the page change events fired for me as expected. I don't understand why no error messages occurred with the current code configuration as this fails pretty silently. Since we've been using GTM which can track pageview events on its own, this wasn't showing in analytics data either.

[ccorda]

FWIW I just tried on another site and it worked no problem:

From reading the PR, their reasoning is here:
vercel/next.js#16846

Glad we're updating to follow their syntax, but it's not like old sites will have broken analytics.