Skip to content
This repository has been archived by the owner on Sep 29, 2024. It is now read-only.

Review optional configuration #28

Merged
merged 6 commits into from
Oct 6, 2018
Merged

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Oct 5, 2018

Some configuration parameters are optional when they shouldn't be, and vice versa:

  • Certificate authority (make mandatory)
  • Credentials (make optional)

Fixes #26

@keeshux keeshux added the enhancement New feature or request label Oct 5, 2018
@keeshux keeshux added this to the 1.1.1 milestone Oct 5, 2018
@keeshux keeshux self-assigned this Oct 5, 2018
@keeshux keeshux force-pushed the review-optional-configuration branch from f236aba to 7940576 Compare October 5, 2018 18:03
Fix up nullability qualifiers in TLSBox.

Fixes #26
@keeshux keeshux force-pushed the review-optional-configuration branch 2 times, most recently from 290cf54 to adf5611 Compare October 6, 2018 14:10
@keeshux keeshux force-pushed the review-optional-configuration branch from adf5611 to 441c904 Compare October 6, 2018 14:23
@keeshux keeshux merged commit f5161a0 into master Oct 6, 2018
@keeshux keeshux deleted the review-optional-configuration branch October 6, 2018 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant