Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameter guards for all methods #84

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Jan 14, 2025

What's New?

  • adds parameter guards to all functions that were missing them before

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 force-pushed the PSG-5735-add-param-guards branch from 5ca6042 to 20dc5fb Compare January 14, 2025 20:00
@ctran88 ctran88 marked this pull request as ready for review January 14, 2025 20:01
Base automatically changed from PSG-5734-update-sigs to main January 14, 2025 23:02
@ctran88 ctran88 force-pushed the PSG-5735-add-param-guards branch from 20dc5fb to 47d3d04 Compare January 15, 2025 17:17
@ctran88 ctran88 merged commit 7f6b79e into main Jan 15, 2025
4 checks passed
@ctran88 ctran88 deleted the PSG-5735-add-param-guards branch January 15, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants