From d473e31e73aa1bf90bade19949589e0ae76b9c72 Mon Sep 17 00:00:00 2001 From: Romain Chaffal <188844152+rchaffal-pass@users.noreply.github.com> Date: Mon, 6 Jan 2025 15:09:47 +0100 Subject: [PATCH] (BSR)[PRO] chore: remove deprecated todo --- pro/src/commons/hooks/usePagination.ts | 4 ---- .../__specs__/CollectiveOffersQueryParams.spec.tsx | 2 -- pro/src/pages/IndividualOffer/commons/serializers.ts | 3 --- 3 files changed, 9 deletions(-) diff --git a/pro/src/commons/hooks/usePagination.ts b/pro/src/commons/hooks/usePagination.ts index 85ee12a4fe0..6bdaac5566b 100644 --- a/pro/src/commons/hooks/usePagination.ts +++ b/pro/src/commons/hooks/usePagination.ts @@ -27,10 +27,6 @@ export const usePagination = ( } } -// TODO: 27/10/2023 -// we duplicate this hook for now since bookings pages also used it -// once we have adapted bookings pagination we can delete the old one -// this is planned in PC-25444 export const usePaginationWithSearchParams = ( itemsPerPage: number, totalCount: number = 0 diff --git a/pro/src/pages/CollectiveOffers/__specs__/CollectiveOffersQueryParams.spec.tsx b/pro/src/pages/CollectiveOffers/__specs__/CollectiveOffersQueryParams.spec.tsx index 4489c5163ac..db9082885d8 100644 --- a/pro/src/pages/CollectiveOffers/__specs__/CollectiveOffersQueryParams.spec.tsx +++ b/pro/src/pages/CollectiveOffers/__specs__/CollectiveOffersQueryParams.spec.tsx @@ -25,8 +25,6 @@ import { renderWithProviders } from 'commons/utils/renderWithProviders' import { CollectiveOffers } from '../CollectiveOffers' -//TODO : extract inital values and constant to reduce code duplication with CollectiveOffers.spec.tsx - vi.mock('react-router-dom', async () => ({ ...(await vi.importActual('react-router-dom')), useNavigate: vi.fn(), diff --git a/pro/src/pages/IndividualOffer/commons/serializers.ts b/pro/src/pages/IndividualOffer/commons/serializers.ts index 7e3f55c3470..1e5796e2d18 100644 --- a/pro/src/pages/IndividualOffer/commons/serializers.ts +++ b/pro/src/pages/IndividualOffer/commons/serializers.ts @@ -30,9 +30,6 @@ export const serializeDurationMinutes = ( export const serializeExtraDataForPatch = ( formValues: Partial ): PostOfferBodyModel['extraData'] | undefined => { - // TODO: change api create and update offer in order not to save - // extra data fields that's aren't link to offer subCategory - const extraData: PostOfferBodyModel['extraData'] = {} extraData.author = formValues.author extraData.gtl_id = formValues.gtl_id