From 5af37d2304fd78ad080fc1d1eecbd042ce17fac4 Mon Sep 17 00:00:00 2001
From: Gergana Velikova <gergana.velikova@pasqal.com>
Date: Mon, 23 Oct 2023 15:35:30 +0200
Subject: [PATCH] naming updates and restructiring; added for completeness on
 this branch history

---
 qadence/__init__.py                           |  4 ++--
 qadence/errors/__init__.py                    |  6 ------
 qadence/{noise.py => errors/readout_error.py} | 13 +++++++++++++
 qadence/exceptions/__init__.py                |  6 ++++++
 qadence/{errors => exceptions}/errors.py      |  0
 5 files changed, 21 insertions(+), 8 deletions(-)
 rename qadence/{noise.py => errors/readout_error.py} (91%)
 create mode 100644 qadence/exceptions/__init__.py
 rename qadence/{errors => exceptions}/errors.py (100%)

diff --git a/qadence/__init__.py b/qadence/__init__.py
index c4f673fe..102125ed 100644
--- a/qadence/__init__.py
+++ b/qadence/__init__.py
@@ -10,7 +10,7 @@
 from .blocks import *
 from .circuit import *
 from .constructors import *
-from .errors import *
+from .exceptions import *
 from .execution import *
 from .measurements import *
 from .ml_tools import *
@@ -43,7 +43,7 @@
     ".blocks",
     ".circuit",
     ".constructors",
-    ".errors",
+    ".exceptions",
     ".execution",
     ".measurements",
     ".ml_tools",
diff --git a/qadence/errors/__init__.py b/qadence/errors/__init__.py
index dbc249b0..e69de29b 100644
--- a/qadence/errors/__init__.py
+++ b/qadence/errors/__init__.py
@@ -1,6 +0,0 @@
-from __future__ import annotations
-
-from .errors import NotPauliBlockError, NotSupportedError, QadenceException
-
-# Modules to be automatically added to the qadence namespace
-__all__ = []  # type: ignore
diff --git a/qadence/noise.py b/qadence/errors/readout_error.py
similarity index 91%
rename from qadence/noise.py
rename to qadence/errors/readout_error.py
index 5bcb912f..774cc837 100644
--- a/qadence/noise.py
+++ b/qadence/errors/readout_error.py
@@ -1,3 +1,16 @@
+
+
+# uniform incorporation of noise (make sure counting is correct as discussed with Roland)
+# add suggestions on shot noise (gaussian and poisson -
+# what is the best way to incorporate these in comparison to uniform)?
+# add to backend
+# use measurements architecture
+# check circ, qiskit, tket, pennylane noise models
+# add proper citations where needed
+# remove from quantum_model as this is not general enough!
+# tests!!
+
+
 from __future__ import annotations
 
 from abc import ABC, abstractmethod
diff --git a/qadence/exceptions/__init__.py b/qadence/exceptions/__init__.py
new file mode 100644
index 00000000..dbc249b0
--- /dev/null
+++ b/qadence/exceptions/__init__.py
@@ -0,0 +1,6 @@
+from __future__ import annotations
+
+from .errors import NotPauliBlockError, NotSupportedError, QadenceException
+
+# Modules to be automatically added to the qadence namespace
+__all__ = []  # type: ignore
diff --git a/qadence/errors/errors.py b/qadence/exceptions/errors.py
similarity index 100%
rename from qadence/errors/errors.py
rename to qadence/exceptions/errors.py