Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for check_run, check_suite ? #7

Closed
brad-decker opened this issue Jul 19, 2019 · 7 comments
Closed

add support for check_run, check_suite ? #7

brad-decker opened this issue Jul 19, 2019 · 7 comments

Comments

@brad-decker
Copy link

I need to hook into merge when check_run or check_suite actions are called because we use circle ci with github checks and it doesn't post status updates to the commits to trigger on 'status' when this feature is enabled. Thoughts?

image

@bjchambers
Copy link

Any update on this? It would be helpful for running in response to CircleCI checks.

@pascalgn
Copy link
Owner

Sorry, I thought I had already replied!

I'm not sure about this feature: We're also using Circle CI, and when a build finished, the status event is triggered just fine. As it says in the documentation:

As an example, one common use is for continuous integration services to mark commits as passing or failing builds using status.

@pascalgn
Copy link
Owner

By the way, I'm not against this feature. There's already a PR #8, but no reply there so far

@pascalgn
Copy link
Owner

pascalgn commented Nov 9, 2019

This still isn't fixed, but I've added this as limitation to the README for now

@pascalgn
Copy link
Owner

pascalgn commented Apr 1, 2020

I think this was fixed with #60. However, feel free to reopen this or create a new issue if you disagree or if there are any other problems! 👍

@pascalgn pascalgn closed this as completed Apr 1, 2020
@shugybugy-assaf
Copy link

@pascalgn For protected branches it still does not merge.

@pascalgn
Copy link
Owner

Are you sure that's related to the check_run/check_suite events? Or is it a separate issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants