-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for on.schedule.cron? #37
Comments
Sorry, I read this but forgot to reply! 😇 Yes, it's a good idea, and shouldn't be a big change! 👍 If you want, you can take a shot at it, otherwise I will do it when I find the time! |
Cool! I could do a PR but it would mean testing it on my side, which would also mean finding some way of hosting it if I am not mistaken. I am actually in the middle of building my own Probot app now... once I have that squared away I will have a better idea of how to tackle this. |
@Mike-EEE I created PR #39 for it, but I currently don't have time to test it. If you want to try it out, you can use the commit from the PR like this: steps:
- name: automerge
uses: "pascalgn/automerge-action@8744297c4b2d2a54c03017838422a0265c4b8df4" |
Wow it is sooooo cool that you can point actions to commits. It's like building webservice by hash. 😆 So interesting! Excitement aside, I am afraid the new coolness produces another error: Looks like it's complaining about the
I appreciate the efforts, though! I hope to be able to take a look into this once I wrap up my own app. 🤞 |
Yeah, unfortunately the schedule event looks much different than the other events... I think I fixed it now, but you need to use a different commit, it's |
@Mike-EEE I have merged this PR into master now! After some time, I will delete the branch, so the commit you're probably referencing now will be gone. Please update your automerge config file to reference the latest commit (from the current README), so that you won't run into any problems! |
Great! Thanks for the heads up and the efforts, @pascalgn. 👍 |
Hey there... cool action. :)
I am wanting to use it to automerge generated CHANGELOGs as part of our release management. To do so, I am having to create a pull request. However, due to this issue no event gets fired.
Not a fan of personal access tokens, I started thinking... why not use
on.schedule.cron
? I tried and it is not a supported event with this action, apparently:https://github.com/ExtendedXmlSerializer/NextRelease/commit/78faf75f6375216bf65e55825dc26c3f567fa9a5/checks?check_suite_id=341442778
So I wanted to reach out here to see if it might be possible to support this event or am I off my rocker (again 😆)?
Thank you for any consideration/assistance. 👍
The text was updated successfully, but these errors were encountered: