-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed best_matching_locale signature #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasabanov
changed the title
Return
Return Sep 28, 2024
Option<&str>
instead of Option<String>
, add examplesOption<&str>
instead of Option<String>
pasabanov
added
enhancement
New feature or request
performance
Improve performance, speed, or resource usage
refactor
Improving code structure without adding new functionality
labels
Sep 28, 2024
skibon02
force-pushed
the
main
branch
2 times, most recently
from
September 28, 2024 12:55
22f1921
to
74bd58a
Compare
Use `IntoIterator` remove vec! from examples
pasabanov
changed the title
Return
Changed best_matching_locale signature
Sep 28, 2024
Option<&str>
instead of Option<String>
pasabanov
approved these changes
Sep 28, 2024
pasabanov
added a commit
that referenced
this pull request
Oct 1, 2024
1. Changed best_matching_locale signature 2. Added tests for template parameter types 3. Changed PosixLocale signature 4. Refactored tests 5. Updated code examples in doc comments and README.md --------- Co-authored-by: Petr Sabanov <[email protected]>
pasabanov
added a commit
that referenced
this pull request
Oct 1, 2024
1. Changed best_matching_locale signature 2. Added tests for template parameter types 3. Changed PosixLocale signature 4. Refactored tests 5. Updated code examples in doc comments and README.md --------- Co-authored-by: Petr Sabanov <[email protected]>
pasabanov
added a commit
that referenced
this pull request
Oct 1, 2024
1. Changed best_matching_locale signature 2. Added tests for template parameter types 3. Changed PosixLocale signature 4. Refactored tests 5. Updated code examples in doc comments and README.md --------- Co-authored-by: Petr Sabanov <[email protected]>
pasabanov
added a commit
that referenced
this pull request
Oct 1, 2024
1. Changed best_matching_locale signature 2. Added tests for template parameter types 3. Changed PosixLocale signature 4. Refactored tests 5. Updated code examples in doc comments and README.md --------- Co-authored-by: Petr Sabanov <[email protected]>
pasabanov
added a commit
that referenced
this pull request
Oct 1, 2024
1. Changed best_matching_locale signature 2. Added tests for template parameter types 3. Changed PosixLocale signature 4. Refactored tests 5. Updated code examples in doc comments and README.md --------- Co-authored-by: Petr Sabanov <[email protected]>
pasabanov
added a commit
that referenced
this pull request
Oct 1, 2024
1. Changed best_matching_locale signature 2. Added tests for template parameter types 3. Changed PosixLocale signature 4. Refactored tests 5. Updated code examples in doc comments and README.md --------- Co-authored-by: Petr Sabanov <[email protected]>
pasabanov
added a commit
that referenced
this pull request
Oct 1, 2024
1. Changed best_matching_locale signature 2. Added tests for template parameter types 3. Changed PosixLocale signature 4. Refactored tests 5. Updated code examples in doc comments and README.md --------- Co-authored-by: Petr Sabanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
performance
Improve performance, speed, or resource usage
refactor
Improving code structure without adding new functionality
tests
Adding or fixing tests
user-experience
Usability or satisfaction of the product
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Describe changes
best_matching_locale
function signature frombcp47
, andposix
, toPosixLocale
signature fromstruct PosixLocale<'a>
tostruct PosixLocale<T: AsRef<str>>
.README.md
.