Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying snippet #1

Open
lorensr opened this issue Aug 27, 2016 · 1 comment
Open

Specifying snippet #1

lorensr opened this issue Aug 27, 2016 · 1 comment

Comments

@lorensr
Copy link

lorensr commented Aug 27, 2016

  1. Commit hash and line numbers - easiest to implement, most brittle, relies on PRs to update
  2. Commit hash and search terms for start/end - need to update commit manually, and you can check if it is still relevant
  3. Search terms and branch name - updates automatically, might break if search terms are not found
  4. Search terms and branch name - we follow every commit and notify when relevant lines are modified

I prefer branch. Can you do line numbers and keep track of how those line numbers change based on git? So I specify lines 10-20 on master/file.js, and when there's a new commit that adds two lines at line 15, my YAML/JSON gets auto-changed to lines 10-22? If not, I'd prefer search terms, and notifying only when the search term breaks.

@stubailo
Copy link
Member

Yeah I think we'll only be able to do the simplest approach -- 1 -- for the hackathon, since we ended up focusing on the reader experience and didn't want to work on building out CI-type functionality. But I like the idea of specifying line numbers and trying to track how they change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants