Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartKeepr: Option to display and filter part id #645

Closed
wants to merge 2 commits into from

Conversation

chrkuhlmann
Copy link

Currently PartKeepr assigns an internal ID to each part, but there is no way to filter for that ID or display it as a column.
It would be great if that ID could be used to clearly communicate a part in a multi-user environment.

This modification tries to address that by

  • showing the internal ID as decimal int as well as base-36 int (great for short part labels)
  • adding an internal ID column (hidden by default)
  • Adding the internal ID to the filter panel (base-36 ids can be searched by prefixing with a # sign)

Hope you like the modifications and keep up the great work

}, {
header: i18n("Internal ID"),
dataIndex: 'id',
//renderer: Ext.util.Format.htmlEncode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please removed commented out code

@Drachenkaetzchen
Copy link
Member

I will have a look at this PR after 1.0.0 has been released

@Drachenkaetzchen
Copy link
Member

It would be nice if you could remove the commented out code in line 300 of PartsGrid

@Drachenkaetzchen
Copy link
Member

@chrkuhlmann ping

@Drachenkaetzchen Drachenkaetzchen added this to the 1.0.1 milestone Aug 2, 2016
@Drachenkaetzchen
Copy link
Member

@chrkuhlmann please fix the open issues so I can merge the PR

@ckuhlmann
Copy link

@FELICITUS
I'm currently on a travel, will try to do this on Thursday.

@chrkuhlmann
Copy link
Author

I've updated the pull request with the change you asked for. Sorry it took so long for such a simple change.

@Drachenkaetzchen
Copy link
Member

No worries, it happens :) I have to check if it can be merged, as there were some changes in the filter logic yesterday

@Drachenkaetzchen
Copy link
Member

I just manually merged the changes. I additionally highlighted the internal ID field to clarify what the # number is, as well as support for searching by the base36 value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants