-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PartKeepr: Option to display and filter part id #645
Conversation
}, { | ||
header: i18n("Internal ID"), | ||
dataIndex: 'id', | ||
//renderer: Ext.util.Format.htmlEncode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please removed commented out code
I will have a look at this PR after 1.0.0 has been released |
It would be nice if you could remove the commented out code in line 300 of PartsGrid |
@chrkuhlmann ping |
@chrkuhlmann please fix the open issues so I can merge the PR |
@FELICITUS |
I've updated the pull request with the change you asked for. Sorry it took so long for such a simple change. |
No worries, it happens :) I have to check if it can be merged, as there were some changes in the filter logic yesterday |
I just manually merged the changes. I additionally highlighted the internal ID field to clarify what the # number is, as well as support for searching by the base36 value. |
Currently PartKeepr assigns an internal ID to each part, but there is no way to filter for that ID or display it as a column.
It would be great if that ID could be used to clearly communicate a part in a multi-user environment.
This modification tries to address that by
Hope you like the modifications and keep up the great work