Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add specific node versions #9198

Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 11, 2024

Pull Request

Issue

#9187 removed specifying exact Node versions from the CI workflow. As a consequence, it is now unclear which exact Node version Parse Server was tested with and is compatible with. For developers to be able to trust that Parse Server works with a specific Node version, this PR re-introduced exact Node version definitions in the CI workflow.

TODO:

  • With the next Parse Server major release, the engine version in package.json also must contain for each major Node version a specific min. version that it has been tested with.

Approach

Copy link

parse-github-assistant bot commented Jul 11, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (8e43700) to head (37d02ba).
Report is 55 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9198   +/-   ##
=======================================
  Coverage   94.14%   94.14%           
=======================================
  Files         186      186           
  Lines       14750    14750           
=======================================
  Hits        13887    13887           
  Misses        863      863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit ea86512 into parse-community:alpha Jul 11, 2024
26 of 27 checks passed
@mtrezza mtrezza deleted the ci/add-specific-node-versions branch July 11, 2024 16:25
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 17, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 3, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants