-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no warning dialog before deleting config parameter #1323
Comments
I like the idea. Would you be willed to add this one? |
At the moment not, but maybe someone wants to pick it up. Seems to be a good first PR. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@davimacedo can you reopen please, PR in the works |
Sure! |
PR merged |
@davimacedo When can we expect the next release? I would like to see this feature added, after 6 months. |
Yes we should definitely do a release, if no one beats me to it I'll do the release notes tomorrow! |
Go for it @TomWFox . We have a lot of good stuff here ready to be released. |
Issue
When deleting a Parse Config parameter by clicking on the trash icon the parameter is deleted without showing a warning dialog.
As it can happen that the trash icon is clicked by mistake, one wouldn't easily see which parameter has been deleted in a long list of parameters. There is also no built-in way to easily restore a key and value that has been deleted by mistake.
Suggested solution
Add a warning dialog for the user to confirm the deletion. Similar to the warning dialog when deleting a row.
The warning dialog should at least include the parameter's key name.
Environment Setup
Steps to reproduce
--
Logs/Trace
--
The text was updated successfully, but these errors were encountered: