Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage including some dependency files sometimes #249

Open
doughsay opened this issue Feb 12, 2021 · 1 comment
Open

Coverage including some dependency files sometimes #249

doughsay opened this issue Feb 12, 2021 · 1 comment

Comments

@doughsay
Copy link

I'm running excoveralls in an umbrella. If I run mix coveralls -u at the top level, or if I cd into a specific application's directory and just run mix coveralls, it will include some random files from dependencies:

Finished in 9.2 seconds
271 doctests, 4 properties, 101 tests, 0 failures

Randomized with seed 987334
----------------
COV    FILE                                        LINES RELEVANT   MISSED
  0.0% /home/chris/src/noreaga/deps/mox/lib/mox      756        1        1
 51.9% lib/bson/id_server.ex                         101       27       13
  0.0% lib/mix/tasks/ci.module_filenames.ex          144       26       26
  0.0% lib/mix/tasks/ua_inspector.maybe_downloa       19        3        3
  0.0% lib/peek.ex                                    12        0        0
 71.9% lib/peek/actor.ex                             471       64       18
... continues

The first file should not be here; the rest are correct.

I get the same thing with mix coveralls -u at the top level, but with an incorrect file path:

... other coverage from other apps...
  0.0% apps/peek//home/chris/src/noreaga/deps/m      756        1        1
 51.9% apps/peek/lib/bson/id_server.ex               101       27       13
  0.0% apps/peek/lib/mix/tasks/ci.module_filena      144       26       26
  0.0% apps/peek/lib/mix/tasks/ua_inspector.may       19        3        3
  0.0% apps/peek/lib/peek.ex                          12        0        0
 71.9% apps/peek/lib/peek/actor.ex                   471       64       18
... continues
@doughsay
Copy link
Author

I found what might be a related issue here: #109

But in my case I don't think this is solvable with the ignore feature, and also, I believe ignoring dependencies should be a natural behavior of excoveralls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant