Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project fails to build with Git submodule #179

Open
Tracked by #77
danirabbit opened this issue Aug 23, 2021 · 3 comments
Open
Tracked by #77

Project fails to build with Git submodule #179

danirabbit opened this issue Aug 23, 2021 · 3 comments
Assignees

Comments

@danirabbit
Copy link

Describe the bug

It looks like we're unable to build NaSC because it relies on a git submodule

To Reproduce
https://github.com/elementary/appcenter-reviews/pull/77/checks?check_run_id=3403685174

Expected behavior
Since Flatpak has a built-in concept of vendoring, it might be better to use modules in your Flatpak manifest instead.

We encountered a similar issue in another app and the developer decided to add a build option here: https://github.com/ryonakano/konbucase/pull/68/files

@parnoldx
Copy link
Owner

I can build it with this without problems. https://github.com/parnold-x/nasc/blob/master/.github/workflows/main.yml#L17

Otherwise, no time right now to fiddle more with this flatpack stuff.

@ckruse
Copy link

ckruse commented Sep 3, 2021

It looks like the github builder doesn't have network access, so the cloning fails

@ChildishGiant
Copy link

Is there any chance this could get looked at? I'd love NaSC to be available again on the AppCenter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants