Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen: Preserve attrs and add #[allow(clippy::all)] #784

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Codegen: Preserve attrs and add #[allow(clippy::all)] #784

merged 3 commits into from
Jan 17, 2023

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Jan 16, 2023

Closes #775 and allows arbitrary attributes to be kept as needed on codegen module.

@niklasad1
Copy link
Member

niklasad1 commented Jan 16, 2023 •
edited
Loading

I agree with this it's not much to do when this code is generated from the metadata however I wonder if clippy::style is sufficient here but probably more future-proof with clippy::all :)

@montekki montekki mentioned this pull request Jan 17, 2023
Merged
@jsdw jsdw merged commit 26b8a81 into master Jan 17, 2023
@jsdw jsdw deleted the jsdw-preserve-attrs branch January 17, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated code should be clippy-friendly
3 participants
@jsdw @niklasad1 @lexnv