Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove the last bits of unknown_os in the code base #9718

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Remove the last bits of unknown_os in the code base #9718

merged 2 commits into from
Sep 9, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Sep 7, 2021

No description provided.

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 7, 2021
@bkchr bkchr requested a review from tomusdrw as a code owner September 7, 2021 11:44
gilescope
gilescope approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (cargo fmt will reduce the diffs)

@TriplEight
Copy link
Contributor

TriplEight commented Sep 8, 2021 •
edited
Loading

Lovely!
I wonder how does this solve the current issues which are red on master.

@bkchr
Copy link
Member Author

bkchr commented Sep 8, 2021

@TriplEight how is your comment related to this pr?

@TriplEight
Copy link
Contributor

@bkchr I was looking what could fix master and found it, now just curious.

@bkchr
Copy link
Member Author

bkchr commented Sep 8, 2021

Okay :) Yeah regarding the errors on master. Master uses the exact same CI image? Did you tried to delete the cache?

@bkchr bkchr merged commit a8a040c into master Sep 9, 2021
@bkchr bkchr deleted the bkchr-remove-unknown-os branch September 9, 2021 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gilescope gilescope gilescope approved these changes

@dvdplm dvdplm dvdplm approved these changes

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkchr @TriplEight @dvdplm @gilescope