This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Various networking fixes for v0.2 #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed an additional commit that reports a node as unresponsive if it fails to open a ping substream. This should help disconnect from unresponsive nodes quicker and help with sync. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug where syncing doesn't work is not really improved by these changes, but I think it's because we keep bouncing between nodes that refuse us because they are full, and because we have random disconnects. Both problems were fixed by unreleased PRs. Once this code has been deployed to more than a few nodes, syncing should hopefully work reliably again.