Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Democracy module events #697

Merged
merged 8 commits into from
Sep 10, 2018
Merged

Democracy module events #697

merged 8 commits into from
Sep 10, 2018

Conversation

gavofyork
Copy link
Member

Part of #696

@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Sep 9, 2018
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor naming nit

Tabled(PropIndex, Balance, Vec<AccountId>),
Started(ReferendumIndex, VoteThreshold),
Passed(ReferendumIndex),
Failed(ReferendumIndex),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we come up with a different name for this case? This introduces some ambiguity with the result of dispatching the proposal. Is there a special word in English for an unsuccessful vote?

Copy link
Contributor

@pepyakin pepyakin Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about?

  1. NotPassed
  2. KeepStatusQuo

@pepyakin pepyakin added A8-looksgood and removed A0-please_review Pull request needs code review. labels Sep 10, 2018
@gavofyork gavofyork mentioned this pull request Sep 10, 2018
12 tasks
@gavofyork gavofyork merged commit ed29fc6 into master Sep 10, 2018
@gavofyork gavofyork deleted the gav-more-events branch September 10, 2018 12:40
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
* Add getters for `Module`

* Return `Iterator` instead
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants