Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Network improvements #374

Merged
merged 9 commits into from
Jul 19, 2018
Merged

Network improvements #374

merged 9 commits into from
Jul 19, 2018

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 18, 2018

Ping all the active connections every 30 seconds with a timeout of 30 seconds.
If a node doesn't respond, disconnect it.

@tomaka tomaka added A0-please_review Pull request needs code review. M4-core labels Jul 18, 2018
@tomaka tomaka changed the title Ping active connections Network improvements Jul 19, 2018
@tomaka
Copy link
Contributor Author

tomaka commented Jul 19, 2018

Pushed a commit that denies connection attempts from a node we're already connected to.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 19, 2018

Pushed another commit that ignores our Kademlia-only connections for the purpose of max_peers.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 19, 2018

Fixed a few other issues:

  • The Kademlia and Dot protocols would sometimes open, but the code would consider that they failed to open. The connection would stay open and be detected at the next round. In other words, this fix should just make things quicker to run.

  • We now close inactive Kademlia connections after 20 seconds.

  • We no longer reconnect to former peers for the sole purpose of pinging them.

@gavofyork gavofyork merged commit 7e19044 into paritytech:master Jul 19, 2018
@gavofyork gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jul 19, 2018
@tomaka tomaka deleted the ping branch July 19, 2018 13:24
JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this pull request Apr 21, 2021
* Crude attempt at finding open ports (paritytech#346)

* added example test for frontier (paritytech#343)

* added example test for frontier

* added npm run non-ci-test

* move staking test spec to node/chainspec (paritytech#335)

* init

* hide staking test spec behind test-staking feature flag

* clean

* comment staking test genesis config for readability

* move test spec to separate file

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

Co-authored-by: Antoine Estienne <[email protected]>
Co-authored-by: Amar Singh <[email protected]>
Co-authored-by: Crystalin <[email protected]>

* Crystalin testweek watch (paritytech#347)

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

* Adds support for test watch

* Cleaned package.json

* Prevent test to run at start of watch

* Restore optimization for cargo build

Co-authored-by: Stephen Shelton <[email protected]>

* Unskip tests (paritytech#357)

* Unskip `fetch genesis block by hash`

* Remove timeouts

* Unskip block gas limit tests

* Remove `opt-level = 0` from Cargo.toml

* Unskip

* Test contract factory (paritytech#351)

* added deployContractByName and  contractSources

* added getcompiled function

* increase timeout for testfilterapi

* change contract name and add sourcecode

* Fix fixture requirement

* update package and json

Co-authored-by: Crystalin <[email protected]>

* Gorka remove intra test dependencies (paritytech#355)

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

* Adds support for test watch

* Cleaned package.json

* Prevent test to run at start of watch

* Restore optimization for cargo build

* Allow for non-finalization and ParentHash specification in createAndFinalizeBlock

* Make test-block tests non-dependent by using non-finalized chains

* Separate tests to make them non-dependent and parametrize tx hashes and nonces in test-txpool

* it instead of step in test-version

* setup providers before tests in test-ethers.ts

* Create a block before tests to avoid one depend on the other in test-nonce

* it for step in test-receipt

* import constants for test-staking

* Attemp at parametrizing test-filter-api tests

* attemp at parametrizing test-revert-receipt

* remove mocha-steps from tests

* make test-subscription tests non-dependent

* comply with prettier

* Add support for retrieving the hash of the generated block

* Make test-trace-filter tests non-dependent

* balance-tests non-dependent

* Non-dependent tests for test-polkadot-api

* Add test-fork-chain tests

* remove unnecesary timeouts

* Use context provider for test-ether.ts

* Remove currentId from test-filter-api since we are uninstalling all filters from test to test

* Join balance test setups and check balance at each block

* Rename variables to camelCase in tests

* small introduced bug in test-pool-pending when camelCasing variables

* Use a different account for test-revert-receipt deployment contract to avoid non-determinism of the nonce

* shorten line because of editconfig

* Separate test-subscription and test-subscription-past-events.ts

* remove single letter variable in test-filter-api

* Small cosmetic changes

* revert changes in package.json

* Remove beforeEach and substitute it for common function

* change var for let or const

Co-authored-by: Stephen Shelton <[email protected]>
Co-authored-by: Crystalin <[email protected]>

* Crystalin remove solc (paritytech#362)

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

* Adds support for test watch

* Cleaned package.json

* Prevent test to run at start of watch

* Restore optimization for cargo build

* Allow for non-finalization and ParentHash specification in createAndFinalizeBlock

* Make test-block tests non-dependent by using non-finalized chains

* Separate tests to make them non-dependent and parametrize tx hashes and nonces in test-txpool

* it instead of step in test-version

* setup providers before tests in test-ethers.ts

* Create a block before tests to avoid one depend on the other in test-nonce

* it for step in test-receipt

* import constants for test-staking

* Attemp at parametrizing test-filter-api tests

* attemp at parametrizing test-revert-receipt

* remove mocha-steps from tests

* make test-subscription tests non-dependent

* comply with prettier

* Add support for retrieving the hash of the generated block

* Make test-trace-filter tests non-dependent

* balance-tests non-dependent

* Non-dependent tests for test-polkadot-api

* Add test-fork-chain tests

* remove unnecesary timeouts

* Use context provider for test-ether.ts

* Remove currentId from test-filter-api since we are uninstalling all filters from test to test

* Join balance test setups and check balance at each block

* Rename variables to camelCase in tests

* small introduced bug in test-pool-pending when camelCasing variables

* Use a different account for test-revert-receipt deployment contract to avoid non-determinism of the nonce

* shorten line because of editconfig

* Separate test-subscription and test-subscription-past-events.ts

* remove single letter variable in test-filter-api

* Small cosmetic changes

* revert changes in package.json

* Remove beforeEach and substitute it for common function

* change var for let or const

* Removes solc from tests

* Fixes path for contract tests

* Adds formatting for compiled contracts

Co-authored-by: Stephen Shelton <[email protected]>
Co-authored-by: Gorka Irazoqui <[email protected]>

* Typescript test refactoring (paritytech#364)

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

* Adds support for test watch

* Cleaned package.json

* Prevent test to run at start of watch

* Restore optimization for cargo build

* Allow for non-finalization and ParentHash specification in createAndFinalizeBlock

* Make test-block tests non-dependent by using non-finalized chains

* Separate tests to make them non-dependent and parametrize tx hashes and nonces in test-txpool

* it instead of step in test-version

* setup providers before tests in test-ethers.ts

* Create a block before tests to avoid one depend on the other in test-nonce

* it for step in test-receipt

* import constants for test-staking

* Attemp at parametrizing test-filter-api tests

* attemp at parametrizing test-revert-receipt

* remove mocha-steps from tests

* make test-subscription tests non-dependent

* comply with prettier

* Add support for retrieving the hash of the generated block

* Make test-trace-filter tests non-dependent

* balance-tests non-dependent

* Non-dependent tests for test-polkadot-api

* Add test-fork-chain tests

* remove unnecesary timeouts

* Use context provider for test-ether.ts

* Remove currentId from test-filter-api since we are uninstalling all filters from test to test

* Join balance test setups and check balance at each block

* Rename variables to camelCase in tests

* small introduced bug in test-pool-pending when camelCasing variables

* Use a different account for test-revert-receipt deployment contract to avoid non-determinism of the nonce

* shorten line because of editconfig

* Separate test-subscription and test-subscription-past-events.ts

* remove single letter variable in test-filter-api

* Small cosmetic changes

* revert changes in package.json

* Remove beforeEach and substitute it for common function

* change var for let or const

* Removes solc from tests

* Fixes path for contract tests

* Adds formatting for compiled contracts

* Refactor tests

* Fix formatting

* Limit concurrency to half cpus for ts tests

* Fixes github action typo

Co-authored-by: Stephen Shelton <[email protected]>
Co-authored-by: Gorka Irazoqui <[email protected]>

* Antoine update testweek readme typos (paritytech#369)

* added instructions to readme

* update package lock

* Add missing contracts to definition (paritytech#368)

* Add Callee, Caller, Incrementer

* Update test-trace

* Remove unused

* Move blockscout tracer to util/tracer

* Test for txpool multiple transactions (paritytech#367)

* Improve pending pool test

* Rephrase comment

* Better naming for txpool tests

* Split txpool multiple test for more independance

* Fixes few test expectations

* Adds test for future transaction

* Rename eth pool correctly

* Fixes node listeners

Co-authored-by: tgmichel <[email protected]>

* Fixes typo in variable name

* Added test for block gas in smart contract (paritytech#370)

* VSCode debugger (support for TS tests) (paritytech#348)

Add a VSCode debugger config with CodeLLDB.
TS tests can be debugged by first starting the node in the debugger, then launching DEBUG_MODE=true npm run test-single in the test folder (modify package.json to change the test file).

* Adds test for filter trace pagination (paritytech#373)

* Fixes trace filter test

Co-authored-by: Stephen Shelton <[email protected]>
Co-authored-by: Antoine Estienne <[email protected]>
Co-authored-by: Amar Singh <[email protected]>
Co-authored-by: tgmichel <[email protected]>
Co-authored-by: girazoki <[email protected]>
Co-authored-by: nanocryk <[email protected]>
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* Ensure minimal validator count

Fixes paritytech#362

* Remove needless retain

* Slash validators on new session insteead of every block

Closes paritytech#369

* Trigger OnAssetChanged

Fixes paritytech#363

* Update acceleration of setup_trustee to 1000

- Closes paritytech#371

* Slash maximum between 1% of jackpot and minimum penalty

Closes paritytech#374

* Update wasm

* 1% instead of 1/10!!!
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* Endow root account 100PCX

.

* Rename to BalanceSet as balances also has this :(

* Rename to initialize_legacy_validators() to make it more explicit

* Increase minimal penalty

* Add two tech members

* Complete tech members

* Add immortal validators

* Add set_immortals()

* Ensure new immortabls are all validators

* New weights for set_minimum_penalty() and set_sessions_per_era()

* Ignore immortals for passing the tests

* Add mainnet bootnodes

* Fix build_wasm.sh
liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants