This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
svyatonik
reviewed
Jun 29, 2018
substrate/runtime/staking/src/lib.rs
Outdated
@@ -578,11 +578,11 @@ impl<T: Trait> Module<T> { | |||
if let Some(rem) = Self::slash(v, early_era_slash) { | |||
let noms = Self::current_nominators_for(v); | |||
let total = noms.iter().map(Self::voting_balance).fold(Zero::zero(), |acc, x| acc + x); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting:
--> /home/svyatonik/dev/polkadot/substrate/runtime/staking/src/lib.rs:580:76
|
580 | let total = noms.iter().map(Self::voting_balance).fold(Zero::zero(), |acc, x| acc + x);
| ^^^ consider giving this closure parameter a type
|
= note: type must be known at this point
on this line when trying to run build.sh
svyatonik
added
A4-gotissues
and removed
A0-please_review
Pull request needs code review.
labels
Jun 29, 2018
gavofyork
added
A0-please_review
Pull request needs code review.
and removed
A4-gotissues
labels
Jun 29, 2018
svyatonik
approved these changes
Jun 29, 2018
svyatonik
added
A8-looksgood
and removed
A0-please_review
Pull request needs code review.
labels
Jun 29, 2018
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* claim unsigned * more test * fix * Update claims.rs * Update runtime/src/claims.rs * Update runtime/src/claims.rs * Update runtime/src/claims.rs
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Update substrate * Format code
liuchengxu
added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…-service Introduce subspace-test-runtime and subspace-test-service
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* update jsonrpsee to 0.2.0-alpha.5 * downgrade subxt client * cleanup * make subxt-client compile again * update jsonrpsee v0.2.0-alpha.6 * fix build again * remove needless type hints * cargo fmt * address grumbles * remove remaining type hints * cargo fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.