Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix runtime #266

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Fix runtime #266

merged 2 commits into from
Jun 29, 2018

Conversation

gavofyork
Copy link
Member

No description provided.

@gavofyork gavofyork assigned svyatonik and unassigned svyatonik Jun 29, 2018
@gavofyork gavofyork requested a review from svyatonik June 29, 2018 09:25
@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Jun 29, 2018
@gavofyork gavofyork mentioned this pull request Jun 29, 2018
@@ -578,11 +578,11 @@ impl<T: Trait> Module<T> {
if let Some(rem) = Self::slash(v, early_era_slash) {
let noms = Self::current_nominators_for(v);
let total = noms.iter().map(Self::voting_balance).fold(Zero::zero(), |acc, x| acc + x);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting:

   --> /home/svyatonik/dev/polkadot/substrate/runtime/staking/src/lib.rs:580:76
    |
580 |                     let total = noms.iter().map(Self::voting_balance).fold(Zero::zero(), |acc, x| acc + x);
    |                                                                                           ^^^ consider giving this closure parameter a type
    |
    = note: type must be known at this point

on this line when trying to run build.sh

@svyatonik svyatonik added A4-gotissues and removed A0-please_review Pull request needs code review. labels Jun 29, 2018
@gavofyork gavofyork added A0-please_review Pull request needs code review. and removed A4-gotissues labels Jun 29, 2018
@svyatonik svyatonik added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jun 29, 2018
@gavofyork gavofyork merged commit 43b2ed3 into master Jun 29, 2018
@gavofyork gavofyork deleted the gav-fix-runtime branch June 29, 2018 10:13
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
* claim unsigned

* more test

* fix

* Update claims.rs

* Update runtime/src/claims.rs

* Update runtime/src/claims.rs

* Update runtime/src/claims.rs
JoshOrndorff added a commit to moonbeam-foundation/substrate that referenced this pull request Apr 21, 2021
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* Update substrate

* Format code
liuchengxu added a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
…-service

Introduce subspace-test-runtime and subspace-test-service
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
* update jsonrpsee to 0.2.0-alpha.5

* downgrade subxt client

* cleanup

* make subxt-client compile again

* update jsonrpsee v0.2.0-alpha.6

* fix build again

* remove needless type hints

* cargo fmt

* address grumbles

* remove remaining type hints

* cargo fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants