Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Contracts: expose charge_storage to chain_extension #14712

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Contracts: expose charge_storage to chain_extension #14712

merged 3 commits into from
Aug 17, 2023

Conversation

pgherveou
Copy link
Contributor

No description provided.

@pgherveou pgherveou requested a review from athei as a code owner August 4, 2023 13:52
@pgherveou pgherveou requested a review from a team August 4, 2023 13:52
@pgherveou pgherveou added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 4, 2023
athei
athei suggested changes Aug 5, 2023
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to re-export Diff so that the type can be constructed. Best to do that from chain_exntension.

@pgherveou pgherveou added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Aug 5, 2023
@pgherveou pgherveou requested a review from athei August 5, 2023 15:37
@athei athei requested a review from agryaznov August 6, 2023 19:13
@pgherveou
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 0cdf702 into master Aug 17, 2023
10 of 11 checks passed
@paritytech-processbot paritytech-processbot bot deleted the pg/add_charge_storage branch August 17, 2023 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agryaznov agryaznov agryaznov approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgherveou @athei @agryaznov