This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[fix docs compiler warnings] Glutton pallet #14664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2023 06:06
sacha-l
added
A0-please_review
joepetrowski
approved these changes
Jul 28, 2023
Comment on lines
82
to
+84
| /// The computation limit has been updated. | ||
| ComputationLimitSet { compute: FixedU64 }, | ||
| ComputationLimitSet { | ||
| /// The computation limit. |
There was a problem hiding this comment.
Annoying that we say "compute" everywhere else and "computation" here.
There was a problem hiding this comment.
Yep agree. Right now the goal is to fix the warnings. We may want to do a pass on renaming some the variables to be more accurate in a follow-up. For this one, it makes more sense to use the term "computation" over "compute" imo.
NachoPal
approved these changes
Jul 28, 2023
ggwpez
approved these changes
Jul 28, 2023
|
Please also add |
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 7 missing doc warnings in the Glutton pallet