This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fixes and improvements for PoC-1 Testnet #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
changed the title
rphmeier
reviewed
May 7, 2018
| /// Compare two fractions. | ||
| pub trait CompareRationals { | ||
| /// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero. | ||
| fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool; |
rphmeier
reviewed
May 7, 2018
| } | ||
| // AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted | ||
| // to overflow the stack. | ||
| Self::compare_rationals(d2, r2, d1, r1) |
There was a problem hiding this comment.
maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.
rphmeier
approved these changes
May 7, 2018
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
* Add clippy/rustfmt checks to CI Add clippy check to CI Apply uses correctly Specify runs-on Use checkout specified from check-prettier Try specifying toolchain with clippy as components Apply to correct action Specify nightly without date Use 'rustup component add clippy' instead of toolchain Uses on steps Typo Specify rustfmt and clippy in rust-toolchain file Try only rustfmt Undo Revert rust-toolchain file Add --workspace arg to clippy * rustup clippy in init.sh * Introduce 'install toolchain' step for Clippy * Add rustfmt check Add rustfmt check -- * Update .rustfmt.toml to remove license checking (for now) * Enforce rustfmt rules on codebase * Update Cargo.lock * Resolve clippy complaints * Apply rustfmt * Appease clippy @ node/parachain/src/chain_spec.rs Co-authored-by: Joshy Orndorff <[email protected]> * Prefer unwrap_or_else to unwrap_or * Avoid borrowed-box * Add a pre-commit hook for rustfmt/clippy using rusty-hook Co-authored-by: Joshy Orndorff <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]>
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* btcbridge CandidateTx and records withdraw cache * Fix precision and initialization error * Initialize balance of alice same with activation_per_share * Tweak initial intention profile * fix bug for withdraw in canonize, add no_withdrawal flag * Can not unstake when still in frozen * Fix some bug * Tweak session_length and sessions_per_era * Fix bug: Only candidate confirmed can create new proposal * Fix unexpect deposit * Tweak staking fees * Fix bug: Add unexpect in Candidate to handle unexpect deposit * Fix/match precision (paritytech#131) * fix pending order precision * add tests * Update genesis_config * Fix when candidate initialize * Recover AccountMap to support btc register * Update genesis BlockHeader * Fix select utxo must balance > 0 * move best index set before deposit/withdraw in canonize * Fix build error * Modify > irr_block as >= * Fix bug: Only candidate is not confirmed can modifi it status * Fix btc transaction correlation * Adjust PCX precision in session reward (paritytech#134) * Fix/match precision (paritytech#132) * fix pending order precision * add tests * add reserve last * 1. Fix UTXOList bug (paritytech#136) 2. Update genesis_config irr_block from 0 to 2 * Remove String (paritytech#137) * Reserve initial nomination (paritytech#138) * Fix wasm build error * Init nominees of initial intenions (paritytech#139) * UTXO only store value > 0 * Init channel (paritytech#140) * Init channel relationship * Init genesis intention * chance channel name (paritytech#141) * fix fill fee (paritytech#142) * Tweak parameters
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
* Separate out subspace-primitives from subspace-runtime * Introduce `NewFull` struct in subspace-node Also expose the `service` module in public. * Make subspace-node a library
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Update to rc6. * Update runtime. * Update node to rc6. * Update client. * Fix node. * Add option to enable telemetry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.