Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Benchmark pallet sudo #13880

Merged
merged 24 commits into from
May 11, 2023
Merged

Benchmark pallet sudo #13880

merged 24 commits into from
May 11, 2023

Conversation

Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Apr 11, 2023 •
edited
Loading

closes #13812

polkadot companion: paritytech/polkadot#7118
cumulus companion: paritytech/cumulus#2514
polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h

@Doordashcon Doordashcon marked this pull request as ready for review April 18, 2023 20:48
@Doordashcon
Copy link
Contributor Author

Hello @ggwpez, does the benchmark bot handle generating the weights.rs file?

@ggwpez
Copy link
Member

ggwpez commented Apr 19, 2023 •
edited
Loading

bot bench $ runtime dev pallet_sudo

Hello @ggwpez, does the benchmark bot handle generating the weights.rs file?
Yes, lets see if it can push to your branch.

@ggwpez
Copy link
Member

ggwpez commented Apr 19, 2023

bot clean
bot bench $ pallet dev pallet_sudo

@command-bot
Copy link

command-bot bot commented Apr 19, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2703621 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_sudo. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 40-511d547c-0799-41cb-b776-c4d3a5ade0f0 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 19, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_sudo has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2703621 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2703621/artifacts/download.

@Doordashcon Doordashcon mentioned this pull request Apr 23, 2023
Merged
ggwpez
ggwpez approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
The sudo and sudo_as could also use a benchmark, but this is a good start.

frame/sudo/src/lib.rs Outdated Show resolved Hide resolved
frame/sudo/src/lib.rs Outdated Show resolved Hide resolved
muharem
muharem approved these changes Apr 26, 2023
View reviewed changes
frame/sudo/src/benchmarking.rs Outdated Show resolved Hide resolved
@muharem muharem added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes F3-breaks_API This PR changes public API; next release should be major. labels Apr 26, 2023
@muharem
Copy link
Contributor

muharem commented Apr 26, 2023

@Doordashcon also needs companion PR for cumulus.
please make sure you get all approves for companions before merging.

@muharem muharem removed the B1-note_worthy Changes should be noted in the release notes label Apr 26, 2023
@Doordashcon
Copy link
Contributor Author

yeah wanted to run the bot again to generate the weights.
can anyone use the benchmark bot?

@ggwpez
Copy link
Member

ggwpez commented May 9, 2023

bot bench $ pallet dev pallet_sudo

@command-bot
Copy link

command-bot bot commented May 9, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2804254 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_sudo. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 24-da8711ff-f313-4b8a-808f-fcc85b329cd6 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 9, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_sudo has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2804254 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2804254/artifacts/download.

ggwpez
ggwpez approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Companion will need to be updated with the new weight functions, then we should be good.
Thanks!

@Doordashcon
Copy link
Contributor Author

Doordashcon commented May 10, 2023 •
edited
Loading

CI is not happy :(

@ggwpez
Update Cargo.lock
6c3acef 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member

ggwpez commented May 10, 2023

bot merge

@paritytech paritytech deleted a comment from paritytech-processbot bot May 10, 2023
@paritytech paritytech deleted a comment from paritytech-processbot bot May 10, 2023
@ggwpez
Copy link
Member

ggwpez commented May 10, 2023

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/cumulus#2514

@KiChjang
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit a87e56f into paritytech:master May 11, 2023
@juangirini
Copy link
Contributor

/tip small

@substrate-tip-bot
Copy link

@juangirini A small tip was successfully submitted for Doordashcon (12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips tip

@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@gilescope gilescope mentioned this pull request Jun 18, 2023
Merged
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jul 11, 2023
@AurevoirXavier
Companion of paritytech/substrate#13880
d79bf26
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@Doordashcon @ggwpez @nathanwhit
Benchmark pallet sudo (paritytech#13880)
4133787 
* set_key

* v2

* update runtime

* cargo fmt

* remove commenting

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_sudo

* impl weights

* sudo & sudo_as

* where

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_sudo

* update weights

* cargo fmt

* Update Cargo.lock

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
@Daanvdplas Daanvdplas mentioned this pull request Jul 24, 2023
Closed
@dmitrylavrenov dmitrylavrenov mentioned this pull request Oct 29, 2024
Open
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@muharem muharem muharem approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@gpestana gpestana gpestana approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit F3-breaks_API This PR changes public API; next release should be major.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmark pallet sudo
7 participants
@Doordashcon @ggwpez @muharem @KiChjang @juangirini @gpestana @sam0x17